Community
Participate
Working Groups
bundle: org.eclipse.ecf.provider.filetransfer version: 3.1.0.v20100906-1425 I am trying to fix up some compiler warnings in Equinox/p2 bundles (Bug 342661) and it caused me to look at the bundle manifest for the org.eclipse.ecf.provider.filetransfer bundle. There are a couple of things which jump out as strange: - x-internal=false is unnecessary (false is the implied default) - you shouldn't have an x-friends list if x-internal=false (or doesn't exist) - this will confuse the bundle tooling. Export packages from manifest: org.eclipse.ecf.internal.provider.filetransfer;x-internal:=true, org.eclipse.ecf.provider.filetransfer;x-friends:="org.eclipse.equinox.p2.repository", org.eclipse.ecf.provider.filetransfer.browse, org.eclipse.ecf.provider.filetransfer.events.socket;version="1.0";x-friends:="org.eclipse.ecf.provider.filetransfer.httpclient", org.eclipse.ecf.provider.filetransfer.identity;x-internal:=false, org.eclipse.ecf.provider.filetransfer.outgoing, org.eclipse.ecf.provider.filetransfer.retrieve;x-internal:=false, org.eclipse.ecf.provider.filetransfer.util
DJ is correct about the x-internal:=false being unnecessary. DJ is also correct that you should not specify the x-internal and x-friends directive both on the same pachage, but I don't see any packages in the Export-Package list for org.eclipse.ecf.provider.filetransfer that has both x-internal and x-friends. Instead what I see is an x-friends list that is out of date for the p2 friends. Because of bug 321819 it looks like p2 moved the code that uses the ECF package org.eclipse.ecf.provider.filetransfer from the org.eclipse.equinox.p2.repository bundle to the org.eclipse.equinox.p2.transport.ecf bundle.
Does p2 still tap into non API anyway? I would expect corresponding enhancement requests filed against ECF in that case.
As I recall, these changes were introduced by one of the p2 team for a previous version...to deal with NTLMv2 proxy issues...but I can't remember who from the p2 team it was. I thought it was possibly Henrik Lindberg. In any case, I think we should try to track down who added them and determine which of the markup needs to remain there, and which doesn't. Obviously the 'false' attributes can be removed, but the friends attributes is what I mean. Please just propose changes to the manifest that work with the new p2, and we'll apply the patch.
Pascal/Henrik: do you know what the right answer should be here for the shape of the manifest after the recent refactoring of the p2 ecf transport bundles? Thanks.
(In reply to comment #4) > Pascal/Henrik: do you know what the right answer should be here for the shape > of the manifest after the recent refactoring of the p2 ecf transport bundles? > Thanks. I did not do any of the NTLMv2 work - have no idea why those settings were made, sorry...
I've removed the x-internal:=false and pushed to master. I'll leave this open until we've settled the question about whether this is still needed: org.eclipse.ecf.provider.filetransfer;x-friends:="org.eclipse.equinox.p2.repository",
Resolving, as I never got any response to question posed in comment 6 about remaining 'strange' entries.
