Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342733 - [validation] JSP editor: validator, problems view and editor disagree
Summary: [validation] JSP editor: validator, problems view and editor disagree
Status: CLOSED WONTFIX
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: 3.2.3   Edit
Hardware: PC Linux
: P3 minor with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: jst.jsp CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-13 11:41 EDT by arne anka CLA
Modified: 2022-09-07 08:23 EDT (History)
4 users (show)

See Also:


Attachments
Active validation, correct annotations (91.35 KB, image/jpeg)
2012-06-01 02:42 EDT, Jan W CLA
no flags Details
deactived validation and wrong annotations (89.04 KB, image/jpeg)
2012-06-01 02:43 EDT, Jan W CLA
no flags Details
Small project from indigo sp1 with reproducable table.html in it (822.79 KB, application/zip)
2012-06-01 02:44 EDT, Jan W CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description arne anka CLA 2011-04-13 11:41:21 EDT
i very often see the case, where the jsp editor reports several errors with underlining and markers -- but both the validator (run manually) and the problems view say, there are no errors.
not quite so often both editor and problems view report errors the validator does not find.
in all these cases the validator is always right!

apparently both the editor and the problems view need to be more attentive (and responsive) to the results of the validator.


-- Configuration Details --
Product: Eclipse 1.3.2.20110218-0812 (org.eclipse.epp.package.jee.product)
Installed Features:
 org.eclipse.platform 3.6.2.r362_v20110210-9gF78Gs1FrIGnHDHWkEcopoN8AmxeZflGDGKQi
Comment 1 Nitin Dahyabhai CLA 2011-04-13 15:56:14 EDT
Can you give a concrete example?
Comment 2 Nick Sandonato CLA 2011-11-18 15:55:27 EST
Hi Arne,

I know it's been awhile. But is there any way to provide us with an example?
Comment 3 Jan W CLA 2012-06-01 02:42:05 EDT
I have this problem if I change the validation settings. If one activates validation in e.g. jsp or html files and one uses e.g. deprecated html attributes the validatation shows a warning in the problems view, on the left side of the window (yellow exclamation mark) in the vertical ruler and on the right side in the overview ruler and finally as native problem underlined in the editor itself, as all configured in annotations.

However if one chooses to deactivate the validator in build and manually completly and one does revalidate the warning correctly dissapears from problems view and vertical ruler, but the editor still underlines the old places as native problem and the overview ruler on the right side does not get updated, too. This is fixed if you clode eclipse and open it again.

Steps to reproduce:

1. Create html file with one table tag with deprecated width attribute in it:
<table width="100%"></table>
2. Activate html validation if not already active and see the warnings
3. Deactive html validation and see native problem underlines and overview ruler annotation
4. Restart eclipse and see all annotations disappear correctly

While testing I figered out this is not reproducable in a "empty" project with only this test file, but in every real project workspace I have. I attached the smallest one consisting only of a few javascript files. Here must be a different validation bug be related, as the warnings in these files don't dissapear from problems/markers view although validation is completly deactivated. Maybe this is related to the wrong annotations shown in the editor and overview ruler.

I also attached two screenshots showing the correct annotations with validation active and the wrong annotations with validation deactivated (after manually validation of course).
Comment 4 Jan W CLA 2012-06-01 02:42:44 EDT
Created attachment 216625 [details]
Active validation, correct annotations
Comment 5 Jan W CLA 2012-06-01 02:43:12 EDT
Created attachment 216626 [details]
deactived validation and wrong annotations
Comment 6 Jan W CLA 2012-06-01 02:44:19 EDT
Created attachment 216627 [details]
Small project from indigo sp1 with reproducable table.html in it