Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342710 - NPE in SchemaErrorReporter during a build
Summary: NPE in SchemaErrorReporter during a build
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 RC1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 345977 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-04-13 09:22 EDT by Remy Suen CLA
Modified: 2011-05-20 09:24 EDT (History)
2 users (show)

See Also:
ankur_sharma: review+

Attachments
Fix (1.62 KB, patch)
2011-05-05 12:50 EDT, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-04-13 09:22:03 EDT 
I get this in an inner while working with 4.1. The inner workspace has org.eclipse.ui checked out and not other projects.

java.lang.NullPointerException
	at org.eclipse.pde.internal.core.builders.SchemaErrorReporter.validateInclude(SchemaErrorReporter.java:280)
	at org.eclipse.pde.internal.core.builders.SchemaErrorReporter.validateContent(SchemaErrorReporter.java:106)
	at org.eclipse.pde.internal.core.builders.ExtensionPointSchemaBuilder.compileFile(ExtensionPointSchemaBuilder.java:120)
	at org.eclipse.pde.internal.core.builders.ExtensionPointSchemaBuilder.compileSchemasIn(ExtensionPointSchemaBuilder.java:183)
	at org.eclipse.pde.internal.core.builders.ExtensionPointSchemaBuilder.compileSchemasIn(ExtensionPointSchemaBuilder.java:181)
	at org.eclipse.pde.internal.core.builders.ExtensionPointSchemaBuilder.build(ExtensionPointSchemaBuilder.java:66)
	at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:717)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:191)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:228)
	at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:281)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:284)
	at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:340)
	at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:363)
	at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:143)
	at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:241)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 1 Curtis Windatt CLA 2011-04-15 10:53:21 EDT 
As per usual, a computeURL method can return null and we don't account for it.  Marking for RC1 to add a null check and comment the method.
Comment 2 Curtis Windatt CLA 2011-05-05 12:50:43 EDT 
Created attachment 194852 [details]
Fix
Comment 3 Curtis Windatt CLA 2011-05-05 12:51:58 EDT 
Fix does a URL comparison instead of a string comparison and adds a null check.

Ankur, please review and apply for RC1.
Comment 4 Ankur Sharma CLA 2011-05-08 05:44:34 EDT 
+1

Applied to HEAD
Comment 5 Curtis Windatt CLA 2011-05-16 14:25:12 EDT 
*** Bug 345977 has been marked as a duplicate of this bug. ***
Comment 6 Curtis Windatt CLA 2011-05-16 17:33:59 EDT 
Verified the null check exists in I20110514-0800