Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342690 - Felix GoGo Bundle has broken localization and no source bundle
Summary: Felix GoGo Bundle has broken localization and no source bundle
Status: CLOSED FIXED
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Lazar Kirchev CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-13 06:13 EDT by Gunnar Wagenknecht CLA
Modified: 2017-10-05 14:53 EDT (History)
1 user (show)

See Also:

Attachments
screenshot (28.74 KB, image/png)
2011-04-13 06:13 EDT, Gunnar Wagenknecht CLA 		no flags Details
patch for missing localization (738 bytes, patch)
2011-04-13 06:19 EDT, Gunnar Wagenknecht CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gunnar Wagenknecht CLA 2011-04-13 06:13:35 EDT 
Created attachment 193142 [details]
screenshot

Looking at the screenshot it seems the localization info is missing. I also couldn't find the source bundle.
Comment 1 Gunnar Wagenknecht CLA 2011-04-13 06:19:38 EDT 
Created attachment 193143 [details]
patch for missing localization

The localization is a quick one. However, the source code is missing completely in CVS.
Comment 2 Gunnar Wagenknecht CLA 2011-04-13 06:20:31 EDT 
Lazar, can you review and commit the patch and add the missing source bundle?
Comment 3 Lazar Kirchev CLA 2011-04-13 06:27:23 EDT 
(In reply to comment #2)
> Lazar, can you review and commit the patch and add the missing source bundle?

Sure Gunner. 

It is strange that the localization is missing - I see it when I checkout the project, as well as through the web interface to the repository.

As for the source - yes, when I uploaded the gogo jar to the repository, I did not include the source because I intended to use it only for binary distribution. I will fix this.
Comment 4 Lazar Kirchev CLA 2011-04-13 06:29:36 EDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Lazar, can you review and commit the patch and add the missing source bundle?
> 
> Sure Gunner. 
> 
> It is strange that the localization is missing - I see it when I checkout the
> project, as well as through the web interface to the repository.

Yes, you are right - I have added the localization file, but obviously have forgotten to add the manifest header.
Comment 5 Lazar Kirchev CLA 2011-04-13 07:27:32 EDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Lazar, can you review and commit the patch and add the missing source bundle?
> > 
> > Sure Gunner. 
> > 
> > It is strange that the localization is missing - I see it when I checkout the
> > project, as well as through the web interface to the repository.
> 
> Yes, you are right - I have added the localization file, but obviously have
> forgotten to add the manifest header.

I committed the patch and the sources.
Comment 6 Roland Grunberg CLA 2017-10-05 14:53:46 EDT 
This was likely fixed long ago. We no longer ship felix.gogo 0.6.1. The latest verison is 1.x and the oldest is 0.10.0.

Marking as CLOSED (FIXED)