Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342684 - XViewerStyledTextLabelProvider not fully integrated
Summary: XViewerStyledTextLabelProvider not fully integrated
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Nebula (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 major with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Donald Dunne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-13 05:16 EDT by Patrick Pastoor CLA
Modified: 2021-07-05 11:40 EDT (History)
2 users (show)

See Also:

Attachments
IXViewerLabelProvider (29.79 KB, patch)
2011-11-04 11:39 EDT, Jürgen Reichl CLA 		wim.jongman: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Pastoor CLA 2011-04-13 05:16:32 EDT 
The XViewerStyledTextLabelProvider is currently not full integrated in the XViewer:
- It is not possbile to use hide/show columns because clearXViewerColumnIndexCache is only called for XViewerLabelProvider (see CustomizeManager.java:504
- Setting GradientSupport to true will cause crashing the XViewer
- It is not possible to show CellData via the Action in the ContextMenu
- ...

The overall problem is that there are either unchecked casts to XViewerLabelProvider or 'instanceof' conditions for XViewerLabelProvider only.
I assume to check the casts and add the missing 'instanceof' conditions for XViewerStyledTextLabelProvider.
But it would be better to make both LabelProviders (and maybe others in the future) inherit from an IXViewerLabelProvider interface.

Cheers, Patrick
Comment 1 Donald Dunne CLA 2011-08-17 17:15:20 EDT 
sounds fine to me, if you would like to provide the enhancement via a patch,
I'll be happy to take a look
Comment 2 Jürgen Reichl CLA 2011-11-04 11:39:27 EDT 
Created attachment 206470 [details]
IXViewerLabelProvider

XViewerStyledTextLabelProvider fully integrated.
XViewerLabelProvider and XViewerStyledTextLabelProvider implements now the IXViewerLabelProvider.

Additionally I added some new constuctors to support the MVC model.

best regards
Jürgen
Comment 3 Donald Dunne CLA 2011-12-02 10:31:30 EST 
Applied Patch
Comment 4 Donald Dunne CLA 2011-12-02 10:32:01 EST 
Thanks for the contribution.  Everything looks great.  Patch is applied.