Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342614 - Refactor QooxdooResourcesUtil
Summary: Refactor QooxdooResourcesUtil
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.4 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 13:28 EDT by Rüdiger Herrmann CLA
Modified: 2011-04-13 05:41 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2011-04-12 13:28:37 EDT 
All methods in QooxdooResourceUtil utilize the ResourcceManager and each of these methods acquires an instance at the beginning of the method.
These methods could benefit from being member methods of QooxdooResourceUtil and the ResourceManager was a field of this class.
Besides, the class could be renamed to ClientResources or ClientResourceUtil as it no longer provides only qx-specific resources.
What do you think?
Comment 1 Rüdiger Herrmann CLA 2011-04-13 05:40:31 EDT 
I made the changes outlined in the description and renamed QooxdooResourceUtil to ClientResources.
Unforunately, the com.eclipsesource.rap.clientbuilder is also affected: in JsFilesList it references QooxdooResourceUtil

Changes are in CVS HEAD