Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342571 - reduce virgo ide startup memory use
Summary: reduce virgo ide startup memory use
Status: RESOLVED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: tooling (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5.0.RELEASE   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 10:17 EDT by Martin Lippert CLA
Modified: 2012-07-04 12:01 EDT (History)
7 users (show)

See Also:


Attachments
patch received from Daniël van 't Ooster (4.40 KB, patch)
2011-06-06 04:30 EDT, Martin Lippert CLA
no flags Details | Diff
Updated patch (4.28 KB, patch)
2011-06-06 06:07 EDT, Daniël van 't Ooster CLA
mlippert: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Lippert CLA 2011-04-12 10:17:49 EDT
We had several reports regarding the memory consumption of the dm Server tooling while included in STS. This bug is to track progress with these issues.
Comment 1 Martin Lippert CLA 2011-04-12 10:18:07 EDT
https://issuetracker.springsource.com/browse/STS-877
Comment 2 Martin Lippert CLA 2011-06-06 04:30:54 EDT
Created attachment 197374 [details]
patch received from Daniël van 't Ooster

patch I received from Daniël van 't Ooster, that was done based on the old code for the dm server tooling at SpringSource (therefore the old package names in the patch). But the patch should be applied to the new code-base here as well.
Comment 3 Daniël van 't Ooster CLA 2011-06-06 06:07:51 EDT
Created attachment 197382 [details]
Updated patch

Hi,

removed the JDK 1.6 dependency from the patch, the double ended queue is now a normal queue. Intention was to have a FIFO queue, a normal Queue was enough to achieve this, the Deque wasn't needed.

grtz,
Daniël
Comment 4 Daniël van 't Ooster CLA 2011-06-06 07:17:19 EDT
As required by Eclipse IP rules:

I have written 100% of the code, Eclipse is allowed to use the code.
Comment 5 Martin Lippert CLA 2011-06-06 07:36:23 EDT
adapted the patch to the virgo ide codebase (renamed packages) and committed the changes.

Not closing this bug since we still need to figure out how to reduce the footprint of the tooling in general.
Comment 6 Miles Parker CLA 2012-07-03 18:41:50 EDT
I'm inclined to close this one out, as we haven't seen any evidence of excessive memory usage, leaks etc.. in the Virgo IDE tooling. Comments?
Comment 7 Glyn Normington CLA 2012-07-04 05:14:02 EDT
(In reply to comment #6)
> I'm inclined to close this one out, as we haven't seen any evidence of
> excessive memory usage, leaks etc.. in the Virgo IDE tooling. Comments?

Agreed.
Comment 8 Miles Parker CLA 2012-07-04 12:01:11 EDT
Closed based on patch and comment above.