Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342543 - Icon decorators not visible in high contrast mode
Summary: Icon decorators not visible in high contrast mode
Status: RESOLVED FIXED
Alias: None
Product: MAT
Classification: Tools
Component: GUI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 1.8.1   Edit
Assignee: Andrew Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: 300655
  Show dependency tree
 
Reported: 2011-04-12 07:16 EDT by Krum Tsvetkov CLA
Modified: 2018-09-03 09:27 EDT (History)
1 user (show)

See Also:

Attachments
Example with blue arrow indicator (18.26 KB, image/png)
2012-12-04 09:19 EST, Andrew Johnson CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krum Tsvetkov CLA 2011-04-12 07:16:47 EDT 
The icon decorators in the object list view are black and go outside the white icon. Thus they are invisible in high contrast mode.

Steps to Reproduce:
1. On windows use left-alt + left shift + print screen to set accessible mode
2. open a heapdump
3. open the histogram and choose from the context menu "List Objects" with either incoming or outgoing references.
Comment 1 Andrew Johnson CLA 2011-07-07 09:24:00 EDT 
See http://wiki.eclipse.org/UI_Graphics_:_Design_:_Style for some guidelines.
Comment 2 Andrew Johnson CLA 2012-05-18 08:26:22 EDT 
The decorator is visible when the row is selected, which helps a little.
Comment 3 Andrew Johnson CLA 2012-09-14 11:40:06 EDT 
The totals row sum sigma icon is also hard to read - just a faint red partial outline.

These icons are provided by the org.eclipse.mat.api plugin via the org/eclipse/mat/snapshot/query/Icons.java class.
This is meant to be independent of o.e.mat.ui or awt so it can run in batch mode, so we can't easily tell if we are in high contrast mode.
Comment 4 Andrew Johnson CLA 2012-12-04 09:19:02 EST 
Created attachment 224265 [details]
Example with blue arrow indicator

Here is an example screen shot showing the object icon with decorators in blue (40,98,150), the same colour as the array/class indicator. A darker blue would
be (0,64,128). The class and classloader decorators remain black as a comparison.
Does blue or black look best? If black looks best, is the difference small enough
that blue is acceptable given the improved visibility in high contrast mode?
Comment 5 Andrew Johnson CLA 2018-08-26 07:04:27 EDT 
This is also a problem with the new Eclipse dark themes.
Comment 6 Andrew Johnson CLA 2018-08-26 16:17:51 EDT 
Updated the in/out icons, also the sum and @ address icon and superclass icon for better visibility in dark theme mode.
Also updated the overview chart to have more readable text if the foreground colour is too close to background
(as in dark theme mode the canvas is dark gray background, but black foreground).

The HTML reports still have a white background in dark theme.
Comment 7 Eclipse Genie CLA 2018-08-26 16:21:05 EDT 
New Gerrit change created: https://git.eclipse.org/r/128092
Comment 9 Andrew Johnson CLA 2018-08-26 17:43:57 EDT 
The icons have now been updated. The EcliPaint icon editor was very useful, though the icons are now about 600 bytes bigger.
Comment 10 Eclipse Genie CLA 2018-08-27 10:09:13 EDT 
New Gerrit change created: https://git.eclipse.org/r/128137
Comment 12 Eclipse Genie CLA 2018-08-27 10:53:50 EDT 
New Gerrit change created: https://git.eclipse.org/r/128140
Comment 14 Eclipse Genie CLA 2018-08-29 11:40:11 EDT 
New Gerrit change created: https://git.eclipse.org/r/128311
Comment 16 Eclipse Genie CLA 2018-08-29 12:37:25 EDT 
New Gerrit change created: https://git.eclipse.org/r/128317
Comment 18 Eclipse Genie CLA 2018-08-31 07:28:47 EDT 
New Gerrit change created: https://git.eclipse.org/r/128435
Comment 20 Eclipse Genie CLA 2018-08-31 11:44:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/128460
Comment 22 Eclipse Genie CLA 2018-08-31 16:33:18 EDT 
New Gerrit change created: https://git.eclipse.org/r/128480
Comment 24 Eclipse Genie CLA 2018-09-01 05:33:48 EDT 
New Gerrit change created: https://git.eclipse.org/r/128489
Comment 26 Eclipse Genie CLA 2018-09-02 07:23:38 EDT 
New Gerrit change created: https://git.eclipse.org/r/128509
Comment 28 Eclipse Genie CLA 2018-09-02 09:15:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/128511
Comment 30 Eclipse Genie CLA 2018-09-03 09:26:48 EDT 
New Gerrit change created: https://git.eclipse.org/r/128561