Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342540 - Extension point deletion is non-intuitive
Summary: Extension point deletion is non-intuitive
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.7 RC1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 06:55 EDT by Ankur Sharma CLA
Modified: 2011-05-17 05:56 EDT (History)
2 users (show)

See Also:
curtis.windatt.public: review+

Attachments
Patch (1.29 KB, patch)
2011-05-05 08:29 EDT, Ankur Sharma CLA 		no flags Details | Diff
updated patch (1.27 KB, patch)
2011-05-09 11:33 EDT, Ankur Sharma CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ankur Sharma CLA 2011-04-12 06:55:34 EDT 
I20110406-1223

1. Create a new plugin project
2. Create an ext pt.
3. Close schema editor if open
4. Save manifest editor (redundant step)
5. Click NO on confirmation message

The ext pt is still deleted from the list.
Comment 1 Ankur Sharma CLA 2011-04-12 07:16:25 EDT 
This is not really a bug.

The Message box asks if you ALSO want to delete the schema file. When user clicks No, the schema file is kept but the ext pt is deleted.

The message should be made clearer that the ext pt will be deleted but the schema file will be kept.
Comment 2 Curtis Windatt CLA 2011-04-12 10:19:10 EDT 
Easy enough to update the message in RC1
Comment 3 Ankur Sharma CLA 2011-05-05 08:29:38 EDT 
Created attachment 194822 [details]
Patch

Curtis, please review if the message sounds any better?
Comment 4 Curtis Windatt CLA 2011-05-05 15:27:19 EDT 
What about the following:

ExtensionPointsSection_message1=Extension Point has been deleted. Delete the corresponding schema file {0}?\n\nThis operation cannot be undone.
Comment 5 Ankur Sharma CLA 2011-05-09 11:33:00 EDT 
Created attachment 195087 [details]
updated patch
Comment 6 Curtis Windatt CLA 2011-05-09 11:34:28 EDT 
+1
Comment 7 Ankur Sharma CLA 2011-05-09 14:31:42 EDT 
Applied to HEAD
Comment 8 Ankur Sharma CLA 2011-05-17 05:56:41 EDT 
Verified in I20110512-2000