Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342533 - [Model Navigator] Usage of a private constructor in oep.navigator.CreateDiagramAction and CreateDiagramActionProvider
Summary: [Model Navigator] Usage of a private constructor in oep.navigator.CreateDiagr...
Status: CLOSED INVALID
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.7.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Arnaud Cuccuru CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 06:09 EDT by Arnaud Cuccuru CLA
Modified: 2013-03-28 05:27 EDT (History)
3 users (show)

See Also:

Attachments
patch for oep.navigator (1.43 KB, patch)
2011-04-12 06:12 EDT, Arnaud Cuccuru CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arnaud Cuccuru CLA 2011-04-12 06:09:08 EDT 
Methods CreateDiagramAction::getCreationCommandRegistry() and CreateDiagramActionProvider::getCreationCommandRegistry() from oep.navigator make use of a private constructor: 
this.creationCommandRegistry = new CreationCommandRegistry(org.eclipse.papyrus.core.Activator.PLUGIN_ID);

It should be replaced by:
this.creationCommandRegistry = CreationCommandRegistry.getInstance(org.eclipse.papyrus.core.Activator.PLUGIN_ID);
Comment 1 Arnaud Cuccuru CLA 2011-04-12 06:12:16 EDT 
Created attachment 193022 [details]
patch for oep.navigator
Comment 2 Sébastien Gérard CLA 2011-04-28 03:42:26 EDT 
Arnaud, now that you are committer ;-), can you apply the patch and close the bug item?
thanks.
Comment 3 Arnaud Cuccuru CLA 2013-03-28 05:27:02 EDT 
This bug refers to an old version of Papyrus (0.7.1).
In the current version (Kepler M6), the code has been significantly refactored. The bug does not make sense anymore.
Closing the bug.