Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342521 - Toggle refactoring: Move to CRefactoring2
Summary: Toggle refactoring: Move to CRefactoring2
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-refactoring (show other bugs)
Version: 8.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.1.0   Edit
Assignee: Sergey Prigogin CLA
QA Contact: Sergey Prigogin CLA
URL:
Whiteboard:
Keywords:
Depends on: 347599
Blocks:
  Show dependency tree
 
Reported: 2011-04-12 05:00 EDT by Emanuel Graf CLA
Modified: 2012-02-24 20:44 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emanuel Graf CLA 2011-04-12 05:00:39 EDT 
Building the selected file AST can be really slow. CRefactoring2 and
RefactoringASTCache were introduced to fix that. BUT there is still an
unresolved issue with shared AST concurrency, see bug 292851. Using
CRefactoring2 would improve performance a lot and help with the index locking
issue previously mentioned so I suggest that you keep an eye on the bug.
Comment 1 Marc-André Laperle CLA 2011-04-12 12:11:00 EDT 
Also it should be possible to use SourceHeaderPartnerFinder and IASTTranslationUnit.getOriginatingTranslationUnit() instead of using
ToggleNodeHelper.getSiblingFile
Comment 2 Sergey Prigogin CLA 2011-04-12 21:15:52 EDT 
(In reply to comment #0)
> Building the selected file AST can be really slow. CRefactoring2 and
> RefactoringASTCache were introduced to fix that. BUT there is still an
> unresolved issue with shared AST concurrency, see bug 292851. Using
> CRefactoring2 would improve performance a lot and help with the index locking
> issue previously mentioned so I suggest that you keep an eye on the bug.

The concurrency issue with accessing shared AST has been resolved.
Comment 3 Sergey Prigogin CLA 2012-02-24 20:44:49 EST 
Fixed in master.