Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342517 - ConversionManager convertObjectToBoolean should return immutable Boolean.TRUE or Boolean.FALSE appropriately
Summary: ConversionManager convertObjectToBoolean should return immutable Boolean.TRUE...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: All Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 04:34 EDT by Jan CLA
Modified: 2022-06-09 10:32 EDT (History)
0 users

See Also:

Attachments
Patch fixing instances of Boolean.valueOf(true) / Boolean.valueOf(false) in core (11.03 KB, patch)
2011-04-28 17:42 EDT, David Minsky CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan CLA 2011-04-12 04:34:29 EDT 
Build Identifier: 2.0.1.v20100213-r6600

The conversion of "true", "false" results in the manager creating new Boolean instances each and every time. This is not optimal, but also error-prone when doing equality check.

Reproducible: Always
Comment 1 David Minsky CLA 2011-04-28 17:42:34 EDT 
Created attachment 194318 [details]
Patch fixing instances of Boolean.valueOf(true) / Boolean.valueOf(false) in core
Comment 2 David Minsky CLA 2011-04-28 17:43:59 EDT 
Proposing attached patch to correct Boolean.valueOf(true) / Boolean.valueOf(false) usage within EL core to Boolean.TRUE / Boolean.FALSE respectively.
Comment 3 David Minsky CLA 2011-04-29 17:27:50 EDT 
Fix checked into trunk (2.3) at r9284
Comment 4 Eclipse Webmaster CLA 2022-06-09 10:32:26 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink