Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342502 - [client] some diffs not shown properly in compare view
Summary: [client] some diffs not shown properly in compare view
Status: RESOLVED WONTFIX
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 339397
Blocks:
  Show dependency tree
 
Reported: 2011-04-11 19:49 EDT by Susan McCourt CLA
Modified: 2015-05-05 14:54 EDT (History)
2 users (show)

See Also:

Attachments
screenshot of changes that aren't highlighted (160.34 KB, image/png)
2011-04-11 19:51 EDT, Susan McCourt CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-04-11 19:49:19 EDT 
I was playing with the git log UI and found a case where the diffs were not shown properly in the compare page.  Here is my URL (can't be reused directly but this will show you what commit I was looking at.)

http://localhost:8080/coding.html#http://localhost:8080/git/commit/c42d5c57abb2e2bdaeefee24e14755b42e53a0fa/file/m/bundles/org.eclipse.orion.client.core/static/plugins/sampleCommandsPlugin.html?parts=body

I was looking at sampleCommandsPlugin.html (one commit behind the current).  The UI shows where changes are but doesn't highlight anything.
Comment 1 Susan McCourt CLA 2011-04-11 19:51:18 EDT 
Created attachment 192990 [details]
screenshot of changes that aren't highlighted
Comment 2 libing wang CLA 2011-04-12 09:39:07 EDT 
From the screenshot , it seems git diff gives back a huge diff.(actually everything was highlighted , as light grey)
Susan , could you find something like below , in your browser console and paste the response here?


GET http://localhost:8080/git/diff/**********/?parts=diff
Comment 3 libing wang CLA 2011-04-15 11:52:04 EDT 
I think it is duplicated to bug 339397.
Comment 4 Susan McCourt CLA 2011-04-18 16:13:51 EDT 
(In reply to comment #3)
> I think it is duplicated to bug 339397.

you are probably right about this.  I ran into some trouble with git status the other day and set my autocrlf back and used git gui.  So I was back in the state of that bug.
Comment 5 John Arthorne CLA 2015-05-05 14:54:19 EDT 
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html