Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342500 - [client] Use the commit link to show commit details in Log UI
Summary: [client] Use the commit link to show commit details in Log UI
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 19:40 EDT by Susan McCourt CLA
Modified: 2011-09-01 11:41 EDT (History)
2 users (show)

See Also:

Attachments
screenshot (15.39 KB, image/png)
2011-04-11 19:40 EDT, Susan McCourt CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-04-11 19:40:16 EDT 
In the git log UI, there is a list of the commits for my file.
The commit has a link and if I click on it, it takes me to the coding page on that commit.
There is also a flashlight icon in the actions column that appears to do the same thing.

- Unless I'm misunderstanding, the action icon is not needed.  The link is nicer because it lets me open on page or in new tab.
- If we need the action for some reason, the icon is confusing.
Comment 1 Susan McCourt CLA 2011-04-11 19:40:53 EDT 
Created attachment 192989 [details]
screenshot
Comment 2 Szymon Brandys CLA 2011-04-12 05:01:16 EDT 
You are right. When I have time to go back to this, I plan to leave the icon to open the content and use the link to show commit details on the left/right side in the details pane. So far I'm going to leave it as it is.

I'm changing the summary to better match the reality.
Comment 3 Susan McCourt CLA 2011-04-12 11:43:09 EDT 
ok.  I suggest you use the word "Open" rather than the flashlight icon, until we can decide on a better icon.  

We've talked in other pages about having "Open" and "Open with..."
Comment 4 Szymon Brandys CLA 2011-05-18 11:13:59 EDT 
Fixed. The details panel shows commit details and the list of diffs. You may open the compare editor to see changes in diffs too.