Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342499 - Minor update to Hermes parser after migrating EL integration to use the lastest
Summary: Minor update to Hermes parser after migrating EL integration to use the lastest
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 19:09 EDT by Pascal Filion CLA
Modified: 2022-06-09 10:29 EDT (History)
1 user (show)

See Also:

Attachments
Changes required for EL integration to work with the previous changes made to the Hermes parser (817.01 KB, patch)
2011-04-11 19:09 EDT, Pascal Filion CLA 		no flags Details | Diff
Patch for the unit-tests (396.73 KB, patch)
2011-04-11 19:10 EDT, Pascal Filion CLA 		no flags Details | Diff
Latest dev update (842.03 KB, patch)
2011-04-22 14:17 EDT, Pascal Filion CLA 		no flags Details | Diff
Latest unit-tests update (102.29 KB, patch)
2011-04-22 14:17 EDT, Pascal Filion CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Filion CLA 2011-04-11 19:09:04 EDT 
Created attachment 192987 [details]
Changes required for EL integration to work with the previous changes made to the Hermes parser

Migrating the EL integration (bug 338248) to use the latest changes made to the Hermes parser (bug 341523) required making some additional changes. The patches attached to this bug includes those changes.

Note: EL integration is no longer using it's own way of parsing the declaration of a query but uses the new declaration code that was added to Hermes with bug 341523. Minor changes were made to the basic behavior in order for EL to properly extend it.
Comment 1 Pascal Filion CLA 2011-04-11 19:10:14 EDT 
Created attachment 192988 [details]
Patch for the unit-tests
Comment 2 Pascal Filion CLA 2011-04-22 14:17:10 EDT 
Created attachment 193937 [details]
Latest dev update

This patch contains the latest enhancement work. The validators (grammatical and semantic validators) and the content assist have been cleaned and optimized
Comment 3 Pascal Filion CLA 2011-04-22 14:17:44 EDT 
Created attachment 193938 [details]
Latest unit-tests update
Comment 4 John Bracken CLA 2011-04-26 14:59:44 EDT 
I applied the patch, reviewed the code and ran the tests.  All of the tests pass and everything looks good.  +1
Comment 5 Pascal Filion CLA 2011-04-26 18:02:04 EDT 
The patch has been committed into SVN.
Comment 6 Eclipse Webmaster CLA 2022-06-09 10:29:06 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink