Community
Participate
Working Groups
Hi, Since Bug 339880 has been fixed, we should now be able to edit derived facet attributes and derived facet references in the EMF Facet table. Regards, Nicolas
Created attachment 193014 [details] Patch for Bug 342451 Implementation Hi, Please find attached the corresponding implementation in which I've modified org.eclipse.emf.facet.widgets.celleditors and org.eclipse.emf.facet.widgets.nattable plug-ins. I've added NaryAttributeCellEditor and NaryReferenceCellEditor so that we could differentiate the edition of a FacetAttribute with the FacetReference one. I've changed the commit mechanism, which was at first implemented in the editing dialog, using an editing domain. In this new version, dialog are now longer responsible of model modification, they only receive a list to edit, and return the result. I've added several @SuppressWarnings("unchecked") because of the type erasure on generic. I've renamed some "columnDescription" attributes with "column", since ColumnDescription was replaced with Column a while ago. We can now edit derived FacetAttribute and derived FacetReference in a table as long as they have a "setQuery" to do so. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Created attachment 193016 [details] Patch for Bug 342451 Sample for edition testing Hi, Please find attached some test material using the samplemm MetaModel. I've created a facetSet and a querySet to demonstrate the usability of facetReference and facetAttribute in the table. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Created attachment 193154 [details] Patch for Bug 342451 Documentation Hi, Please find attached an updated version of the Table documentation. Updated screenshots are in the next archive. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Created attachment 193155 [details] Patch for Bug 342451 Documentation ScreenShot Hi, Please find attached updated/new versions of the documentation screenshot. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Comment on attachment 193154 [details] Patch for Bug 342451 Documentation Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 512.
Comment on attachment 193155 [details] Patch for Bug 342451 Documentation ScreenShot Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 512.
Comment on attachment 193014 [details] Patch for Bug 342451 Implementation Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 511.
Comment on attachment 193016 [details] Patch for Bug 342451 Sample for edition testing Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 511.
This bug can be marked as resolved.
Created attachment 193224 [details] Patch for Bug 342451 Update Ecore Example Hi, Please find attached an updated version of the Ecore example to demonstrate facet editability with a FacetAttribute and a FacetReference. I've also added some tests in NatTableWidget to avoid "Widget already disposed" exception. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Comment on attachment 193224 [details] Patch for Bug 342451 Update Ecore Example Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed a part of this contribution. Committed revision 514.
Created attachment 193910 [details] Patch for Bug 342451 UI Tests Hi, Please find attached several SWT Bot tests to cover editable facets on sampleMM meta-model. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Created attachment 193915 [details] Patch for Bug 342451 UI Tests Hi, My previous attachment contained a reference to a Zip archive, I removed it in this updated version. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Comment on attachment 193915 [details] Patch for Bug 342451 UI Tests Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 567.
This bug can be closed.
