Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342428 - [Browser] Block browser when not enabled
Summary: [Browser] Block browser when not enabled
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.4 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 08:38 EDT by Tim Buschtoens CLA
Modified: 2011-04-14 03:21 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Buschtoens CLA 2011-04-11 08:38:09 EDT 
In SWT when the browser widget gets disabled( "setEnabled( false )"), the user can no longer interact with the browser content. We should do the same in RAP. There actually already are "block()" and "release()" implementations in IFrame.js, we just have to use them.
Comment 1 Tim Buschtoens CLA 2011-04-11 08:40:29 EDT 
As disabled browser would then probably also support different mouse-cursors.
Comment 2 Tim Buschtoens CLA 2011-04-11 08:42:16 EDT 
For some reasion release() is alrady called Browser#_onload. This is probably incorrect.
Comment 3 Ivan Furnadjiev CLA 2011-04-11 09:07:48 EDT 
(In reply to comment #2)
> For some reasion release() is alrady called Browser#_onload. This is probably
> incorrect.
If I remember correctly, this release() call is added here to avoid two clicks to activate a link in the browser - first click was needed to remove the blocker.
Comment 4 Ivan Furnadjiev CLA 2011-04-14 03:21:13 EDT 
Fixed in CVS HEAD by overwritting the _applyEnabled method to block/release the blocker. I removed the release() in Browser#_onload as it does not make any change.