Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342416 - [1.7] Signature#createIntersectionTypeSignature(..) should take array of signatures
Summary: [1.7] Signature#createIntersectionTypeSignature(..) should take array of sign...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.7.1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 05:50 EDT by Markus Keller CLA
Modified: 2011-08-05 02:54 EDT (History)
1 user (show)

See Also:

Attachments
Proposed fix + regression tests (6.29 KB, patch)
2011-04-11 13:17 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-04-11 05:50:28 EDT 
BETA_JAVA7, follow-up to bug 340059

Sorry, I think I was too confused about the original char[][][] in 
Signature#createIntersectionTypeSignature(..) that I didn't really look at the rest of the signature.

For consistency with other APIs in Signature and for full flexibility, the Signature#createIntersectionTypeSignature(..) methods should be changed to take arrays of signatures (not arrays of type names + isResolved).
Comment 1 Olivier Thomann CLA 2011-04-11 10:25:07 EDT 
(In reply to comment #0)
> For consistency with other APIs in Signature and for full flexibility, the
> Signature#createIntersectionTypeSignature(..) methods should be changed to
> take arrays of signatures (not arrays of type names + isResolved).
Unfortunately there is no consistency for these APIs. Some take a type name, some take a type signature.
I'll change it for type signature if this is what you prefer.
Comment 2 Olivier Thomann CLA 2011-04-11 13:17:42 EDT 
Created attachment 192951 [details]
Proposed fix + regression tests
Comment 3 Olivier Thomann CLA 2011-04-11 13:18:22 EDT 
Released in BETA_JAVA7 branch only
Comment 4 Ayushman Jain CLA 2011-06-29 04:39:54 EDT 
Verified using Eclipse Java 7 Support(Beta) feature patch v20110623-0900.