Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342411 - JDBC column created instead of MySQL catalog column in MySqlColumnLoader
Summary: JDBC column created instead of MySQL catalog column in MySqlColumnLoader
Status: RESOLVED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: Enablement (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.9.1   Edit
Assignee: Brian Fitzpatrick CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 04:50 EDT by Shilpi CLA
Modified: 2011-10-03 20:04 EDT (History)
3 users (show)

See Also:

Attachments
Patch (3.11 KB, patch)
2011-04-11 04:58 EDT, Shilpi CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shilpi CLA 2011-04-11 04:50:23 EDT 
Build Identifier: 1.7.2.v20100914-1028

Reverse engineering from database for MySQL v5.x does not work. 

Reproducible: Always

Steps to Reproduce:
1. Create a connection to MySQL v5.0/5.1
2. Create a new Physical Data Model using Reverse Engineering from Database. Select MySQL database connection created in step1.
3. Select default options and press Finish.
4. No model is created and no error log generated.
Comment 1 Shilpi CLA 2011-04-11 04:58:16 EDT 
Created attachment 192918 [details]
Patch
Comment 2 Robert Samuel CLA 2011-07-26 06:16:36 EDT 
Hi,

Do we have any timeframe for pushing the fix into the CVS?

Just following up...

Thanks,
Robert Samuel.
Comment 3 Brian Fitzpatrick CLA 2011-07-27 15:48:34 EDT 
Well, after looking at this patch, it appears to change the 1.9 API for JDBCTable. We typically don't do API changes in a maintenance release - and DTP 1.9.1 is the next release scheduled to go out the door. So this may need to wait for 1.10 next June before we can get it done.
Comment 4 Brian Fitzpatrick CLA 2011-08-16 13:36:51 EDT 
Ok, just committed the changes to the org.eclipse.datatools.connectivity project and the org.eclipse.datatools.enablememt.mysql project. There's a new branch called "342411" in each project and I've pushed the changes up. 

Just need those changes merged with the master now... So I'll wait to see how this goes before I check in anything else.
Comment 5 Brian Fitzpatrick CLA 2011-09-02 11:43:11 EDT 
Pushed fixes to master for org.eclipse.datatools.connectivity and org.eclipse.datatools.enablement.mysql in git. Hopefully these tweaks will show up in the next build.
Comment 6 Robert Samuel CLA 2011-09-08 07:27:37 EDT 
Brian Fitzpatrick,

Which branch has the fix now? Is this 1.9.1 (or) 1.10?

Also, when will that branched be released?

Please let me know.

Thanks,
Robert Samuel.
Comment 7 Brian Fitzpatrick CLA 2011-09-08 15:36:21 EDT 
Hey Robert!

This fix is finally in the latest 1.9.1 RC4 zip  - the latest nightly build at http://www.eclipse.org/datatools/downloads.php

Can you test the fixes to make sure everything is running right?

--Fitz

(In reply to comment #6)
> Brian Fitzpatrick,
> 
> Which branch has the fix now? Is this 1.9.1 (or) 1.10?
> 
> Also, when will that branched be released?
> 
> Please let me know.
> 
> Thanks,
> Robert Samuel.
Comment 8 Brian Payton CLA 2011-10-03 20:04:05 EDT 
Changing to Resolved Fixed since Fitz has committed the patch.