Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342329 - Tab size not handled properly in XText editor
Summary: Tab size not handled properly in XText editor
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 1.0.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: RC1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-08 15:36 EDT by Samantha Chan CLA
Modified: 2017-09-19 17:13 EDT (History)
3 users (show)

See Also:
sebastian.zarnekow: indigo+

Attachments
proposed patch pls verify (2.95 KB, patch)
2011-05-08 14:16 EDT, Michael Clay CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samantha Chan CLA 2011-04-08 15:36:03 EDT 
Xtext 1.0.2 - I reproduced this problem with the xtext editor.

1)  In Windows -> Preferences -> Editors -> Text Editor -> Displayed tab width, set tab size to 8
2)  Set to show whitespace characters
3)  Open *.xtext file
 => Notice that the tab size is set to 4.  The expected tab width is 8.
4)  Change the tab size to 10 with the editor opened
 => Notice that the tab size is now respected and set to 10.  This is working as expected
5)  Close and reopen the file
  => Notice that the tab size is reverted back to 4.  The expected tab width is 10.
Comment 1 Samantha Chan CLA 2011-04-08 15:40:04 EDT 
Can you please evaluate and let me know if this can be included in XText 2.0?
Comment 2 Sebastian Zarnekow CLA 2011-04-08 16:01:46 EDT 
We'll address this issue.
Comment 3 Samantha Chan CLA 2011-04-08 16:47:42 EDT 
(In reply to comment #2)
> We'll address this issue.

Thanks Sebastian!
Comment 4 Sebastian Zarnekow CLA 2011-05-04 06:11:33 EDT 
Preliminary scheduled for 2.0RC1
Comment 5 Michael Clay CLA 2011-05-08 14:16:57 EDT 
Created attachment 195022 [details]
proposed patch pls verify

additionally affects the following std. editor configuration settings

EDITOR_TAB_WIDTH
EDITOR_SPACES_FOR_TABS
EDITOR_HYPERLINKS_ENABLED
EDITOR_HYPERLINK_KEY_MODIFIER
EDITOR_HYPERLINK_KEY_MODIFIER_MASK
HYPERLINK_COLOR_SYSTEM_DEFAULT
EDITOR_UNDO_HISTORY_SIZE
PREFERENCE_SPELLING_ENABLED
Comment 6 Sven Efftinge CLA 2011-05-09 02:23:28 EDT 
looks good
Comment 7 Michael Clay CLA 2011-05-16 12:49:30 EDT 
pushed to master
Comment 8 Karsten Thoms CLA 2017-09-19 17:01:56 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 9 Karsten Thoms CLA 2017-09-19 17:13:15 EDT 
Closing all bugs that were set to RESOLVED before Neon.0