Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342291 - Use the MPart's 'closeable' value if the part is not being rendered in a perspective
Summary: Use the MPart's 'closeable' value if the part is not being rendered in a pers...
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-08 09:57 EDT by Eric Moffatt CLA
Modified: 2011-05-30 10:47 EDT (History)
1 user (show)

See Also:

Attachments
Use the part's attribute if it's being rendered directly (1.18 KB, patch)
2011-04-08 10:01 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2011-04-08 09:57:11 EDT 
We switched over to using a special tag 'IPresentationEngine.NO_CLOSE' on MPlaceholders in order to support the fact that a part can be closeable in one perspective but not in a different one...

...but we forgot to handle the scenario where the part is being used in a simple RCP app.
Comment 1 Eric Moffatt CLA 2011-04-08 10:01:24 EDT 
Created attachment 192834 [details]
Use the part's attribute if it's being rendered directly
Comment 2 Eric Moffatt CLA 2011-04-08 10:03:13 EDT 
Committed in >20110408. Applied the patch.
Comment 3 Eric Moffatt CLA 2011-04-08 10:03:24 EDT 
Marking FIXED.
Comment 4 Eric Moffatt CLA 2011-04-08 10:27:04 EDT 
Committed in >20110408. Updated the javadoc on the NO_CLOSE tag to specifically call out the two different mechanisms; use the tag on MPlaceholders when using perspectives, otherwise use the MPart's 'isCloseable' attribute.
Comment 5 Eric Moffatt CLA 2011-04-08 10:32:09 EDT 
Tom, I've added bug 342299 to track the issue with the renderer not picking up the state changes after the initial construction...good pickup.