Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342255 - [Theming] Themed Combo and Spinner buttons show also the default button images
Summary: [Theming] Themed Combo and Spinner buttons show also the default button images
Status: RESOLVED WORKSFORME
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-08 05:50 EDT by Kaloyan Radev CLA
Modified: 2011-04-08 08:41 EDT (History)
0 users

See Also:

Attachments
screenshot (1.88 KB, image/png)
2011-04-08 05:51 EDT, Kaloyan Radev CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Radev CLA 2011-04-08 05:50:16 EDT 
Build Identifier: RAP 1.4M6

The Combo and Spinner buttons theming shows the default image if the new ones include transparency around the main arrow.

Reproducible: Always
Comment 1 Kaloyan Radev CLA 2011-04-08 05:51:03 EDT 
Created attachment 192806 [details]
screenshot
Comment 2 Ivan Furnadjiev CLA 2011-04-08 06:04:45 EDT 
Did you use Combo-Button-Icon CSS element to change the icon? Could you post your Combo CSS?
Comment 3 Kaloyan Radev CLA 2011-04-08 06:31:15 EDT 
With Combo-Button-Icon it works fine on 1.4M6, thanks! 

I've used jus Combo-Button  - here's the CSS piece (taken from the 1.3 theming):

Combo-Button {
  background-image: url( "/theme/icons/combo.down.gif" );
}

Anyway it looks like this might mean that some CSS translation are needed for migration from 1.3 to 1.4 but that's OK for me. Maybe it would be nice if this finds its place in the New and Noteworthy section.
Comment 4 Kaloyan Radev CLA 2011-04-08 06:48:06 EDT 
The Spinner-UpButton-Icon & Spinner-DownButton-Icon (not the Spinner-UpButton & Spinner-DownButton I've used) also seem to work fine.
Comment 5 Ivan Furnadjiev CLA 2011-04-08 07:04:02 EDT 
With the old (classic ) default theme we intentionally set the default combo/spinner button icon in Combo-Button#background-image property to be backward compatibility with 1.3. With migration of default theme to the new one (business) this functionality has been lost and the default button icon is now set on the new property Combo-Button-Icon. Thus, we are no longer compatible with 1.3. Maybe we have to correct the CSS doc that states:
<property name="background-image">
  <description>
    Background image, gradient or icon if not specified in
    Combo-Button-Icon for combo drop-down button.
  </description>
</property>
and remove "or icon if not specified in Combo-Button-Icon" or restore the backward compatibility like in old default theme.
Comment 6 Ivan Furnadjiev CLA 2011-04-08 08:41:04 EDT 
Removed "or icon if not specified in XXX-Button-Icon" from CSS XXX-Button#background-image description (Combo, CCombo, Spinner and DateTime). The CSS element XXX-Button-Icon should be used to set the button icon.