Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342242 - Consider to remove the ability to compress responses from RWT
Summary: Consider to remove the ability to compress responses from RWT
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.4 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 341763 342672
  Show dependency tree
 
Reported: 2011-04-08 04:27 EDT by Rüdiger Herrmann CLA
Modified: 2011-04-18 05:38 EDT (History)
0 users

See Also:

Attachments
Fix (14.10 KB, patch)
2011-04-18 05:38 EDT, Rüdiger Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2011-04-08 04:27:00 EDT 
Previously, RWT compressed all of its responses. Since, under some circumstances, compressing responses led to invalid output (bug 259977), it was made configurable (bug 285669).
In general, compressing reponses and the decision when to compress should be handled by the servlet engine. All major servlet engine implementations offer such features, hecne I propose to remove the response compression from RWT entirely.
Comment 1 Ralf Sternberg CLA 2011-04-11 05:36:22 EDT 
I fully agree with this proposal.

We've already agreed to register the concatenated JavaScript as a resource (bug 335545). Those are the largest chunks of code to be delivered to the client. Since static resources cannot be compressed by RAP anyway (as we can't set headers for them), the only remaining responses to be compressed are the lifecycle responses. The majority of these lifecycle responses are rather small and don't need to be compressed.
Comment 2 Rüdiger Herrmann CLA 2011-04-18 05:38:07 EDT 
Created attachment 193470 [details]
Fix

Removes gzip compression for Javascript library requests and normal life cycle requests
Comment 3 Rüdiger Herrmann CLA 2011-04-18 05:38:59 EDT 
Applied patch to CVS HEAD