Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342208 - potential NPE in SystemView$ExpandRemoteObjects.execute()
Summary: potential NPE in SystemView$ExpandRemoteObjects.execute()
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 342560
  Show dependency tree
 
Reported: 2011-04-07 14:44 EDT by David McKnight CLA
Modified: 2011-04-12 09:16 EDT (History)
0 users

See Also:

Attachments
patch to check for null callback (1.55 KB, patch)
2011-04-07 15:10 EDT, David McKnight CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David McKnight CLA 2011-04-07 14:44:08 EDT 
In  SystemView$ExpandRemoteObjects.execute() we have the following code:

if (item != null && !item.isDisposed()) {
    IRSECallback callback = getCallbackForSubChildren(itemToExpand, _toExpand);
    createChildren(item, callback);
    ((TreeItem) item).setExpanded(true);
}

The problem is that getCallbackForSubChildren() can return null and we're not checking for that case.
Comment 1 David McKnight CLA 2011-04-07 15:10:21 EDT 
Created attachment 192773 [details]
patch to check for null callback
Comment 2 David McKnight CLA 2011-04-07 15:14:28 EDT 
I've committed the fix to cvs.