Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342203 - [UI] Java Resources node missing CVS decorator
Summary: [UI] Java Resources node missing CVS decorator
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.servlet (show other bugs)
Version: 3.2.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.4   Edit
Assignee: Israel Gomez Delgado CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks: 391361
  Show dependency tree
 
Reported: 2011-04-07 14:16 EDT by Israel Gomez Delgado CLA
Modified: 2012-10-08 11:56 EDT (History)
1 user (show)

See Also:
ccc: pmc_approved? (david_williams)
ccc: pmc_approved? (raghunathan.srinivasan)
ccc: pmc_approved? (naci.dai)
ccc: pmc_approved? (deboer)
ccc: pmc_approved? (neil.hauge)
ccc: pmc_approved? (kaloyan)
cbridgha: pmc_approved+
cbridgha: review+

Attachments
new Decorator for Java resources node (10.51 KB, patch)
2011-04-07 14:19 EDT, Israel Gomez Delgado CLA 		ccc: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Israel Gomez Delgado CLA 2011-04-07 14:16:46 EDT 
Build Identifier: 3.2.3

the > symbol (cvs Decorator)on the Java Source node is missing when a web project is on CVS control and a rource has been modified inside the node.

This makes it hard to tell what has changed, if you don't have this node uncompressed, because it looks like none of the child nodes have changed.

Reproducible: Always
Comment 1 Israel Gomez Delgado CLA 2011-04-07 14:19:33 EDT 
Created attachment 192767 [details]
new Decorator for Java resources node
Comment 2 Chuck Bridgham CLA 2011-04-08 15:07:30 EDT 
tested looks good - 

Although this seems minor - its been a complaint for many releases
Comment 3 Carl Anderson CLA 2011-04-12 13:05:42 EDT 
PMC Review requested due to UI change
Please note that we would like to put this same change into both WTP 3.2.4 and WTP 3.3 M7


* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.
This is requested by an adopter, IBM.  As Chuck has mentioned, this has been a complaint for many releases.

* Is there a work-around? If so, why do you believe the work-around is insufficient?
Users can expand the Java Resources node to see if there are CVS changes under it, but users expect the CVS decorator to be shown along the entire hierarchy that has changes- not having the CVS decorator on the Java Resources node is quite inconsistent.

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?
This has been tested by hand, and Carl has run the J2EE JUnit bucket against this change.

* Give a brief technical overview. Who has reviewed this fix?
A new decorator is added to properly adapt the Java Resources node (an ICompressedNode) such that the appropriate decorator is shown when a change to a child node is made.
Chuck Bridgham and Carl Anderson have reviewed this fix.

* What is the risk associated with this fix?
Low - the plugin.xml changes are limited to only ICompressedNode
Comment 4 Chuck Bridgham CLA 2011-04-13 17:03:14 EDT 
I'll go ahead and approve this.

Carl - thanks for the explanation.

Many clients have complained of missing changes because this node "hides" these changes without this fix.
Comment 5 Carl Anderson CLA 2011-04-15 10:22:29 EDT 
Committed to R3_2_maintenance and HEAD for WTP 3.2.4 and WTP 3.3 M7.