Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342189 - Another post M6 API change: Where is NodeModelUtils.getTextWithoutHidden(INode)
Summary: Another post M6 API change: Where is NodeModelUtils.getTextWithoutHidden(INode)
Status: CLOSED WONTFIX
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Windows Vista
: P3 critical (vote)
Target Milestone: M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-07 11:58 EDT by Ed Willink CLA
Modified: 2017-09-19 18:10 EDT (History)
1 user (show)

See Also:
sebastian.zarnekow: indigo+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2011-04-07 11:58:57 EDT
NodeModelUtils.getTextWithoutHidden(INode) has gone.

Presumably getTokenText is the replacement; a much better name; I wasn't quite sure whether I cared about hidden text or not.

There is a simple compatibility approach that will avoid breaking consumers when changing APIs despite Eclipse API freeze policy.

If changing the name retain the old name as a deprecated delegator and mark it deprecated (for at least one milestone).

There are also API tools that will enable you to detect that you are changing API wrt the M6 freeze. Please use them.

It would also be nice to see announcements on at least one of cross-project-dev, modeling-pmc, TMF-users.
Comment 1 Sebastian Zarnekow CLA 2011-04-07 12:12:18 EDT
Hi Ed,

sorry for that. An announcement on the tmf mailing list sounds reasonable to me.
Can you update your code or would it help to reintroduce the method?
Comment 2 Ed Willink CLA 2011-04-07 12:23:58 EDT
An updated build is just completing, so I don't care any more. Fortunately MDT/OCL builds run off the latext Xtext repository so we discover quite quickly. However other users may only update at milestones, so I think it would be helpful to have all methods that were present in M6 as deprecated delegators in M7 so that users have between M7 and RC1 to mend their code.
Comment 3 Sebastian Zarnekow CLA 2011-04-07 12:29:27 EDT
Since we aren't aware of other clients on the train that used this method, I'm inclined to not reintroduce it and close this one as won't fix.

Ed, I appreciate your feedback. Please don't hesitate to report any unexpected API breakage or behavioral changes. The good news is: as we are almost done with the our baseline setup, I don't expect any other accidental breaking changes.
Comment 4 Karsten Thoms CLA 2017-09-19 17:59:40 EDT
Closing all bugs that were set to RESOLVED before Neon.0
Comment 5 Karsten Thoms CLA 2017-09-19 18:10:24 EDT
Closing all bugs that were set to RESOLVED before Neon.0