Community
Participate
Working Groups
In the following cases, remote file properties in the Properties view remains "Pending...". 1. RMB on a remote file 2. Double click a remote file
I think this is a duplicate of bug 308783 which has already been fixed and backported, no ? *** This bug has been marked as a duplicate of bug 308783 ***
No. This is not a duplicate of bug 308783. If a remote file is selected by a left mouse button, it works. A right mouse button or doubld click does not.
Any news on this defect?
(In reply to comment #3) > Any news on this defect? I spent some time on Friday investigating this and will look at it again today.
Created attachment 197418 [details] patch to make the part of focus on property sheet update The property sheet is not being updated in the double-click case because, when the editor comes up, the SystemViewPart loses focus (even though the SystemView control retains focus). When the part loses focus, it also loses it's selection event listeners - so the fireSelectionChanged() calls have no effect on the property sheet. One way this can be overcome is by calling getWorkbenchPart().setFocus() as is done in this patch. Does this patch resolve your issues?
The patch does not work for me. The patch for bug 308783 does not work either. I reopened it.
Created attachment 197497 [details] patch using post selection event rather than selection event I think this may depend on whether you're using Helios or Indigo. With Helios and earlier, we need to use fireSelectionChanged() while for Indigo, we need to use firePostSelectionChanged(). This updated patch does both. Can you try with this?
The patch solved both problems, this and bug 308783. Would you backport it to 3.2.x?
I've committed the updated patch and opened bug 348778 for the 3.2.x backport.
This will eventually go into 3.3.1 (not released yet).
Reviewing the code, it looks like an "instanceof IStructuredSelection" is missing or there's a risk of ClassCastException
Created attachment 198723 [details] patch to check for structured selection
(In reply to comment #11) > Reviewing the code, it looks like an "instanceof IStructuredSelection" is > missing or there's a risk of ClassCastException I've attached a patch that has a check for structured selection.
Created attachment 198740 [details] updated patch to account for dialog scenario
I checked in the update.
Patch released for I-builds. Should any patch here be marked obsolete?
(In reply to comment #16) > Patch released for I-builds. > Should any patch here be marked obsolete? I'm not sure since each subsequent patch is a diff based on the previous one.
