Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342028 - Field can be edited even if they are marked as N/A
Summary: Field can be edited even if they are marked as N/A
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 10:09 EDT by Vincent Lorenzo CLA
Modified: 2020-05-01 11:26 EDT (History)
2 users (show)

See Also:
gdupe: indigo+


Attachments
Patch for Bug 342028 Implementation (10.38 KB, patch)
2011-04-28 06:02 EDT, Nicolas Guyomar CLA
gdupe: iplog+
Details | Diff
Patch for Bug 342028 SWTBot Test (37.45 KB, patch)
2011-05-04 07:10 EDT, Nicolas Guyomar CLA
no flags Details | Diff
Patch for Bug 342028 SWTBot (33.84 KB, patch)
2011-05-06 05:58 EDT, Nicolas Guyomar CLA
gdupe: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Lorenzo CLA 2011-04-06 10:09:18 EDT
Steps to reproduce : 
	1/ create an Ecore model with an EClass and an EDataType
	2/ Select the root package and use : Open Ecore Tabular Editor
	3/ The field Serializable is marked as N/A forThe Eclass, but if you double click on it, a combo is open to edit it!
	
	FYI, I can't reproduce this bug in the Interface Column!
Comment 1 Nicolas Guyomar CLA 2011-04-28 06:02:04 EDT
Created attachment 194248 [details]
Patch for Bug 342028 Implementation

Hi,

I've added a new method isSelectedCellEditable() called each time a edit action is perform on a table's cell.

In order to do that, I've modified the EditBinding class so that it uses our own MouseEditAction which calls INatTableWidget2.editSelectedCell(). (before that, only the "Edit" key binding was redirected to this method, which was a mistake)

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 2 Nicolas Guyomar CLA 2011-05-04 07:10:44 EDT
Created attachment 194695 [details]
Patch for Bug 342028 SWTBot Test

Hi,

Please find attached a non regression test perform by SWTBot.
In this patch I also changed :
- the fact that the bot was declared static.
- the way double click is performed is now SWTBot like, as a consequence I removed an unnecessary method from INatTableWidgetInternal:getCellPositionRelativeToDisplay()


(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 3 Nicolas Guyomar CLA 2011-05-06 05:58:09 EDT
Created attachment 194916 [details]
Patch for Bug 342028 SWTBot

Hi,

There was a wrong URI in the previous patch, here is an updated one

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 4 Gregoire Dupe CLA 2011-05-06 11:25:11 EDT
Comment on attachment 194248 [details]
Patch for Bug 342028 Implementation

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 635.
Comment 5 Gregoire Dupe CLA 2011-05-06 11:25:26 EDT
Comment on attachment 194916 [details]
Patch for Bug 342028 SWTBot

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 635.
Comment 6 Gregoire Dupe CLA 2011-05-06 11:26:04 EDT
This bug can be marked as fixed.
Comment 7 Vincent Lorenzo CLA 2011-05-10 03:34:26 EDT
This bug can be marked as closed.