Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342026 - Bug with Open Ecore Tabular Editor and the Load A Customization action Dialog
Summary: Bug with Open Ecore Tabular Editor and the Load A Customization action Dialog
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 09:56 EDT by Vincent Lorenzo CLA
Modified: 2020-05-01 11:27 EDT (History)
2 users (show)

See Also:
gdupe: indigo+


Attachments
Patch for Bug 342026 (1.17 KB, patch)
2011-04-06 11:29 EDT, Nicolas Guyomar CLA
gdupe: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Lorenzo CLA 2011-04-06 09:56:52 EDT
When you open an EPackage in the Ecore Tabular Editor, the following customization is applied : _example_EcoreCustom
(some element are displayed in Bold in the table), but when you use the dialog to Load a Customization, this file appears as not applied.

I think the problem comes from the line 120 in org.eclipse.emf.facet.infra.browser.custom.ui.dialogs.LoadCustomizationsDialog. 
When you are in debug mode, you can see that you compare 2 nsURI to build the initial selected custom list: 
initiallySelectedCustomizationURI = platform:/plugin/org.eclipse.emf.facet.widgets.nattable.examples.ecore/_example_EcoreCustom.uiCustom#/
and availableCustomizationURI = emffacet:/customization/_example_EcoreCustom#/

So this comparison is false -> the custom appears as not applied.
Comment 1 Nicolas Guyomar CLA 2011-04-06 11:29:54 EDT
Created attachment 192655 [details]
Patch for Bug 342026

Hi Vincent,

As a matter of fact, the _example_EcoreTableConfiguration.tableconfiguration file was not using the emffacet protocol to reference the default customization.

Here is a patch fixing this, the customization now appears in the dialog as "loaded" when using the Ecore Tabular example.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 2 Gregoire Dupe CLA 2011-04-06 11:54:21 EDT
Comment on attachment 192655 [details]
Patch for Bug 342026

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 498.
Comment 3 Gregoire Dupe CLA 2011-04-06 11:55:17 EDT
This bug can be marked as fixed.
Comment 4 Vincent Lorenzo CLA 2011-04-27 03:02:42 EDT
This bug can be marked as closed.