Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341933 - [Compatibility] Git repo perspective has big empty space
Summary: [Compatibility] Git repo perspective has big empty space
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1 RC1   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331240
  Show dependency tree
 
Reported: 2011-04-05 11:35 EDT by Paul Webster CLA
Modified: 2011-05-17 08:08 EDT (History)
2 users (show)

See Also:

Attachments
Git repo view pic (103.09 KB, image/png)
2011-04-05 11:35 EDT, Paul Webster CLA 		no flags Details
ModeledPageLayout patch v1 (812 bytes, patch)
2011-05-04 10:56 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2011-04-05 11:35:46 EDT 
Created attachment 192570 [details]
Git repo view pic

See Image.  I can grab the bottom of the git repo view and drag it, although there's nothing underneath.

PW
Comment 1 Remy Suen CLA 2011-05-04 09:04:27 EDT 
Still broken. Resizing doesn't seem to help. Will have to take a look...
Comment 2 Remy Suen CLA 2011-05-04 10:09:55 EDT 
The snippet below will reproduce the problem.

public void createInitialLayout(IPageLayout layout) {
  layout.addView(IPageLayout.ID_OUTLINE, IPageLayout.LEFT, (float) 0.5,
      layout.getEditorArea());
  layout.addView(IPageLayout.ID_PROP_SHEET, IPageLayout.BOTTOM,
      (float) 0.5, layout.getEditorArea());
  layout.addPlaceholder(IPageLayout.ID_PROJECT_EXPLORER,
      IPageLayout.BOTTOM, (float) 0.7, IPageLayout.ID_OUTLINE);
  layout.addPlaceholder(IPageLayout.ID_PROBLEM_VIEW, IPageLayout.BOTTOM,
      (float) 0.6, IPageLayout.ID_PROJECT_EXPLORER);
}
Comment 3 Remy Suen CLA 2011-05-04 10:56:15 EDT 
Created attachment 194722 [details]
ModeledPageLayout patch v1

The part sash container should only be rendered if one of its children are. Otherwise, it shouldn't be there (taking up space).
Comment 4 Remy Suen CLA 2011-05-04 10:58:58 EDT 
(In reply to comment #3)
> Created attachment 194722 [details]
> ModeledPageLayout patch v1

Fix released to CVS HEAD.
Comment 5 Remy Suen CLA 2011-05-17 08:08:32 EDT 
Verified with I20110516-1455 on Windows XP.

Paul, if you see otherwise, please feel free to reopen, thanks.