Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341908 - [Eclipse Platform Extensions] AbstractWizardPage#doCreateControl(Composite) should return the created control
Summary: [Eclipse Platform Extensions] AbstractWizardPage#doCreateControl(Composite) s...
Status: CLOSED FIXED
Alias: None
Product: Sphinx
Classification: Automotive
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Idrissa Dieng CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 09:50 EDT by Ali AKAR CLA
Modified: 2021-07-14 02:14 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ali AKAR CLA 2011-04-05 09:50:08 EDT 
The abstract method AbstractWizardPage#doCreateControl(Composite) is called from the final method AbstractWizardPage#createControl(Composite). 

Actual implementation assume that the developer should call org.eclipse.jface.dialogs.DialogPage#setControl(Control) after creating the control in the  AbstractWizardPage#doCreateControl(Composite), and if u don't do that an exception is raised from org.eclipse.jface.wizard.Wizard#createPageControls(Composite).

It's better that the AbstractWizardPage#doCreateControl(Composite) return the created control then in the final method we call org.eclipse.jface.dialogs.DialogPage#setControl(Control).
Comment 1 Idrissa Dieng CLA 2011-10-07 06:26:40 EDT 
(In reply to comment #0)
> The abstract method AbstractWizardPage#doCreateControl(Composite) is called
> from the final method AbstractWizardPage#createControl(Composite). 
> 
> Actual implementation assume that the developer should call
> org.eclipse.jface.dialogs.DialogPage#setControl(Control) after creating the
> control in the  AbstractWizardPage#doCreateControl(Composite), and if u don't
> do that an exception is raised from
> org.eclipse.jface.wizard.Wizard#createPageControls(Composite).
> 
> It's better that the AbstractWizardPage#doCreateControl(Composite) return the
> created control then in the final method we call
> org.eclipse.jface.dialogs.DialogPage#setControl(Control).

Yes that will usefull & it's better because sometime we got mentioned exception. I will realize corresponding changes & update all concrete classes implementation.
Comment 2 Idrissa Dieng CLA 2011-10-07 08:13:35 EDT 
Fixed as Ali's proposition.

Modifications done in following classes:

* org.eclipse.sphinx.platform.ui.wizards.pages.AbstractWizardPage
* org.eclipse.sphinx.xtendxpand.ui.wizards.pages.XpandConfigurationPage
* org.eclipse.sphinx.xtendxpand.ui.wizards.pages.CheckConfigurationPage
* org.eclipse.sphinx.xtendxpand.ui.wizards.pages.XtendConfigurationPage
* org.eclipse.sphinx.xtendxpand.ui.wizards.pages.OutletsConfigurationPage
Comment 3 Balazs Grill CLA 2021-07-14 02:14:02 EDT 
Mass-closing Resolved tickets