Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341900 - Metatype must support optional 'pid' attribute on <Designate> element.
Summary: Metatype must support optional 'pid' attribute on <Designate> element.
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Compendium (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: John Ross CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 09:15 EDT by John Ross CLA
Modified: 2011-04-06 12:32 EDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (4.70 KB, patch)
2011-04-05 15:29 EDT, John Ross CLA 		tjwatson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Ross CLA 2011-04-05 09:15:58 EDT 
Build Identifier: 

The 4.3 compendium makes the 'pid' attribute on the <Designate> element optional instead of required. The implementation needs to be updated to not automatically reject XML that omits this attribute. The rule is the <Designate> element must have either the 'pid' or 'factoryPid' attribute. Both are also allowed to be present. If both are present, the 'factoryPid' takes precedence and the 'pid' is ignored.

Reproducible: Always
Comment 2 John Ross CLA 2011-04-05 15:29:01 EDT 
Created attachment 192592 [details]
Proposed Patch

This patch takes into account the now optional 'pid' attribute on the <Designate> element. Either 'pid' or 'factoryPid' must be present. If neither are specified, a (new) error message is logged and the entire XML file rejected. If 'factoryPid' is present, 'pid' (present or absent) is ignored entirely.
Comment 3 Thomas Watson CLA 2011-04-06 12:32:18 EDT 
Thanks John!  Patch released.