Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341887 - Tests for new functionality in Equinox console
Summary: Tests for new functionality in Equinox console
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: equinox.framework-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 06:57 EDT by Lazar Kirchev CLA
Modified: 2011-04-05 09:36 EDT (History)
1 user (show)

See Also:

Attachments
Patch providing the necessary tests (12.08 KB, patch)
2011-04-05 07:05 EDT, Lazar Kirchev CLA 		tjwatson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lazar Kirchev CLA 2011-04-05 06:57:38 EDT 
Tests are needed for:
- the new functionality for providing help for an individual command
- the property which disables the console
- the restriction of the telnet access on a particular address of the host
Comment 1 Lazar Kirchev CLA 2011-04-05 07:05:02 EDT 
Created attachment 192540 [details]
Patch providing the necessary tests

The test for the functionality for providing help for individual command is add to the TestCommandExecution class. The test is to execute the help command for one command from the FrameworkCommandProvider and for one command from a custom command provider. The test checks the output of the command.

The test for the property for disabling the console is in TestEquinoxStartWithoutConsole. The test starts a framework with the property for disabling the console set to true and checks that the FrameworkConsoleSession and FrameworkCommandProvider are not registered.

The test for restricting telnet access to a particular network interface is in TestRestricted TelnetHost. It starts a framework with telnet open on localhost and checks that a connection cannot be opened using the ip address of the host.
Comment 2 Thomas Watson CLA 2011-04-05 09:05:29 EDT 
Comment on attachment 192540 [details]
Patch providing the necessary tests

Thanks Lazar
Comment 3 Thomas Watson CLA 2011-04-05 09:06:36 EDT 
Thanks for the test contribution Lazar!  I released the tests with a small change to call Framework.stop() in a couple places where the test framework was left running.
Comment 4 Lazar Kirchev CLA 2011-04-05 09:36:58 EDT 
Thanks for the correction Tom! Somehow I have missed this.