Community
Participate
Working Groups
IDiagramConnectionBindingDef reuses Id property from ISapphirePartDef to mean the id of the connection it is the binding for. This is confusing. There should be a separate ConnectionId property that binds to "connection-id" element. IDiagramConnectionBindingDef should not extend ISapphirePartDef. The binding specification is not a part.
Make sure to update the sdef editor after making this change.
Fix checked in. Note: IDiagramConnectionDef is the visual definition of a connection while IDiagramConnectionBindingDef is tied with diagram connection parts. So IDiagramConnectionBdiningDef needs to extend ISapphirePartDef. IDiagramConnectionDef does not. I've corrected that as well.
> Note: IDiagramConnectionDef is the visual definition of a connection while > IDiagramConnectionBindingDef is tied with diagram connection parts. So > IDiagramConnectionBdiningDef needs to extend ISapphirePartDef. > IDiagramConnectionDef does not. I've corrected that as well. That's exactly backwards. ISapphirePartDef has the properties for defining actions, hints, etc. Those settings are necessary on the connection, not the binding.
You're right the connection definition should extend ISapphirePartDef so it can define actions, action handlers etc. Connection binding def should only concern about how a connection is tied with model elements/properties. Just checked in the fix and hopefully I got it right this time...
Verified. Closing.
