Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341826 - Add a stopgap measure for artifact locking
Summary: Add a stopgap measure for artifact locking
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P1 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: Ian Bull CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-04 13:24 EDT by Ian Bull CLA
Modified: 2011-06-16 12:50 EDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (5.39 KB, patch)
2011-04-04 14:56 EDT, Ian Bull CLA 		no flags Details | Diff
mylyn/context/zip (57.67 KB, application/octet-stream)
2011-04-04 14:56 EDT, Ian Bull CLA 		no flags Details
Patch v2 (7.28 KB, patch)
2011-04-04 16:09 EDT, Ian Bull CLA 		no flags Details | Diff
mylyn/context/zip (81.61 KB, application/octet-stream)
2011-04-04 16:09 EDT, Ian Bull CLA 		no flags Details
Patch v3 (7.30 KB, patch)
2011-04-04 16:21 EDT, Ian Bull CLA 		no flags Details | Diff
mylyn/context/zip (90.01 KB, application/octet-stream)
2011-04-04 16:21 EDT, Ian Bull CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2011-04-04 13:24:53 EDT 
In case we're not happy with the artifact locking, we should provide an easy way to disable it.
Comment 1 Ian Bull CLA 2011-04-04 14:48:44 EDT 
I'm implementing this with a VM args -Declipse.p2.artifact.locking. By default this is true. If you specify false, then no locking will be done.

We may want to make this 'per agent', but since agents aren't named, this might be tricky.
Comment 2 Ian Bull CLA 2011-04-04 14:56:00 EDT 
Created attachment 192494 [details]
Patch v1

This provides a VM arg to control the locking of artifact repositories.
Comment 3 Ian Bull CLA 2011-04-04 14:56:03 EDT 
Created attachment 192495 [details]
mylyn/context/zip
Comment 4 Ian Bull CLA 2011-04-04 16:09:04 EDT 
Created attachment 192500 [details]
Patch v2

This now sets locking 'false' by default. This also enables locking during the test cases which test the artifact locking.
Comment 5 Ian Bull CLA 2011-04-04 16:09:06 EDT 
Created attachment 192501 [details]
mylyn/context/zip
Comment 6 Ian Bull CLA 2011-04-04 16:21:54 EDT 
Created attachment 192504 [details]
Patch v3

This makes the property name 'uglier': eclipse.p2.internal.simple.artifact.repository.locking
Comment 7 Ian Bull CLA 2011-04-04 16:21:57 EDT 
Created attachment 192505 [details]
mylyn/context/zip
Comment 8 Ian Bull CLA 2011-04-04 17:14:39 EDT 
I've released this. For now the value is 'true' by default.
Comment 9 Jeff McAffer CLA 2011-04-05 09:17:07 EDT 
you might consider leaving this bug open.  As I understand it, we wanted the value false by default.  Either that or open another bug to ensure that we change it before shipping.  Would also mark it as high priority so we don't forget.
Comment 10 Ian Bull CLA 2011-04-05 11:43:42 EDT 
done.
Comment 11 Ian Bull CLA 2011-04-12 00:09:28 EDT 
false by default.