Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341745 - tycho-versions-plugin changes feature url in site.xml
Summary: tycho-versions-plugin changes feature url in site.xml
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Tycho (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Tobias Oberlies CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-04 04:37 EDT by Robert Munteanu CLA
Modified: 2021-04-28 16:55 EDT (History)
3 users (show)

See Also:

Attachments
Bugfix for Tycho 0.13 (6.12 KB, patch)
2011-05-04 18:38 EDT, Beat Strasser CLA 		no flags Details | Diff
Bugfix and tests incl correct copyright headers (5.71 KB, patch)
2011-06-13 14:51 EDT, Beat Strasser CLA 		t-oberlies: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Munteanu CLA 2011-04-04 04:37:28 EDT 
Created from:
	TYCHO-558: tycho-versions-plugin changes feature url in site.xml
https://issues.sonatype.org/browse/TYCHO-558

Original Description:
Steps to reproduce:

1. git clone git://mylyn-mantis.git.sourceforge.net/gitroot/mylyn-mantis/mylyn-mantis 
2. cd com.itsolut.mantis.parent
3. mvn org.sonatype.tycho:tycho-versions-plugin:set-version -DnewVersion=3.5.0-SNAPSHOT

Besides the issues reported at TYCHO-426 , I get an incorrect change in site.xml :
{code}
-   <feature url="features/com.itsolut.mantis_feature_3.1.5.qualifier.jar" id="com.itsolut.mantis_feature" version="3.1.5.qualifier">
+   <feature url="com.itsolut.mantis_feature_3.5.0.qualifier" id="com.itsolut.mantis_feature" version="3.5.0.qualifier">
{code}

Original Comments:
== bstrasser ==          [1295566386000]
Fixed in my fork; implementation/tests: https://github.com/b8/sonatype-tycho/commit/fea6052a33ac2c70753c8e7fc721c86a74af3fd7
Comment 1 Tobias Oberlies CLA 2011-05-04 04:20:14 EDT 
I'll look at the contribution once the Tycho sources are in parallel IP at Eclipse.
Comment 2 Beat Strasser CLA 2011-05-04 04:40:36 EDT 
Unfortunately, I currently have only a single branch for several of my contributions to the versioning plugin. I'll create branches from 0.12 for each bugfix and create pull requests from each of them.
Comment 3 Tobias Oberlies CLA 2011-05-04 05:32:17 EDT 
Pull requests in Github are not enough. You need to attach your change as patch to an Eclipse bug, because then you consent to the eclipse.org terms of use [1] and hence license your IP under the EPL.

[1] http://www.eclipse.org/legal/termsofuse.php
Comment 5 Tobias Oberlies CLA 2011-06-03 11:10:30 EDT 
@Beat: The patch looks good, execpt for the copyright header in SiteXmlManipulatorTest

Did you write the test yourself? If yes, please fix the copyright header to specify the right year (probably just "2011") and the right copyright owner. (I am assuming that Sonatype doesn't own your changes...)
Comment 6 Beat Strasser CLA 2011-06-13 14:51:32 EDT 
Created attachment 197917 [details]
Bugfix and tests incl correct copyright headers

Attached a patch which includes the correct copyright headers.
Comment 7 Tobias Oberlies CLA 2011-06-14 11:04:21 EDT 
Patch applied -> commit 1640834

@Beat: Thank you for the contribution. Just a small remark: The updated patch didn't contain any commit information (i.e. the patch didn't work with @git am@ but only with @git apply@). Therefore I had to take the commit information from of the first patch. I would prefer patches in the format of the first patch, i.e. the normal @git format-patch@ output. Thanks!