Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341730 - Strings on the Traditional Mmemory Rendering preferences page unexternalized
Summary: Strings on the Traditional Mmemory Rendering preferences page unexternalized
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-memory (show other bugs)
Version: 8.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Vivian Kong CLA
QA Contact: Ted Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-03 15:53 EDT by Kit Lo CLA
Modified: 2011-04-06 10:23 EDT (History)
4 users (show)

See Also:

Attachments
Traditional Memory Rendering preferences (86.16 KB, image/pjpeg)
2011-04-03 15:53 EDT, Kit Lo CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kit Lo CLA 2011-04-03 15:53:10 EDT 
Created attachment 192428 [details]
Traditional Memory Rendering preferences

I cannot locate the strings on the Traditional Mmemory Rendering preferences page in any of the .properties files in cdt-memory plugins. They may be hard-coded in the plugins. I couldn't find any of the source plugins for cdt-memory to verify. That could be a separate problem.
Comment 1 Andre St. Laurent CLA 2011-04-04 11:54:08 EDT 
The Traditional [memory] Renderer externalizes strings in the file TraditionalRendering_messages.properties (granted, this defies the convention of naming the file "messages.properties").  And, just to make double sure, I skimmed the code to make sure that any hard-coded strings are not exposed via the UI.

My question for you is:  Were you searching through all of CDT for only "messages.properties"?  Or did you look at "*.properties"?
Comment 2 Kit Lo CLA 2011-04-04 12:43:49 EDT 
I saw the TraditionalRendering_messages.properties file. However, I don't see the strings from the preferences page (for example: "Use Global Te&xt Color") in the file.
Comment 3 Andre St. Laurent CLA 2011-04-04 12:55:04 EDT 
Ah, right you are.  Seems that (A) I did not read your initial comment close enough and (B) my skimming of the source was inadequate.  My apologies.  The TraditionalRenderingPreferencePage class does indeed have some hard-coded strings that are exposed via the UI.

I did a more careful examination of the 129 strings that matched by regEx search and it looks to me that the only strings not externalized are in TraditionalRenderingPreferencePage, which you noted originally.  It would probably be a good idea to add these to TraditionalRendering_messages.properties.
Comment 4 Vivian Kong CLA 2011-04-06 10:14:29 EDT 
Fixed in HEAD