Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341729 - Undo in properties view without effect
Summary: Undo in properties view without effect
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BPEL (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: BPEL UI Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-03 15:50 EDT by Tobias Liefke CLA
Modified: 2022-10-03 11:11 EDT (History)
1 user (show)

See Also:


Attachments
Patch for Undo/Redo in properties view (4.10 KB, patch)
2011-04-05 02:51 EDT, Tobias Liefke CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Liefke CLA 2011-04-03 15:50:30 EDT
If the properties view is focused and Edit->Undo is selected (e.g after changing the name of an activity in the view, but other properties are affected, too), that command has no effect.
Comment 1 Tobias Liefke CLA 2011-04-05 02:51:43 EDT
Created attachment 192523 [details]
Patch for Undo/Redo in properties view

As far as I can see, it would be the best solution to let the "AutoUndoCommand" not only record any changes with the undo manager of the DOM model, but also handle the undo/redo calls. The attached patch does exactly that.
Comment 2 Robert Brodt CLA 2011-04-08 12:23:15 EDT
This is a good start, but it has undesirable side-effects ;)

1. Try adding a new activity from the toolpalette, then focus on the property view and ^Z - the activity is removed from the design canvas but the property view still shows the properties for the (now missing!) activity.
2. Add a fault handler, change something in the property view for the Catch, then ^Z several times - NPE
3. add an Assign and configure some assignment operations, then ^Z several times - the undo should update the widgets as the undostack is unloaded, but alas...

Bottom line is that undo/redo still needs a LOT of work :( and this quick fix introduces more problems than it's worth. This is a big task IMO and needs careful investigation, but you are welcome to give it a try ;)