Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341661 - [git][client] Make gitClient.js the same pattern as fileClient.js
Summary: [git][client] Make gitClient.js the same pattern as fileClient.js
Status: RESOLVED INVALID
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-01 14:14 EDT by libing wang CLA
Modified: 2015-04-01 10:12 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description libing wang CLA 2011-04-01 14:14:27 EDT 
We should follow the same pattern as fileClient._doServiceCall function does.
We can put doServiceCall function somewhere in auth.js so that if there is a auth error in the service call the error is handled generically.
Comment 1 Szymon Brandys CLA 2011-04-01 15:11:04 EDT 
I'll take this one. I've been working on gitClient.js recently and will fix that too.
Comment 2 Szymon Brandys CLA 2015-04-01 10:12:25 EDT 
Not sure if it is still relevant. I guess not. If it has to be fixed though, please reopen.