Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341654 - Tycho repositories enables if target-platform-configuration is omitted
Summary: Tycho repositories enables if target-platform-configuration is omitted
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Tycho (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Tobias Oberlies CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-01 13:43 EDT by Tobias Oberlies CLA
Modified: 2021-04-28 16:55 EDT (History)
1 user (show)

See Also:

Attachments
Demostrate bug (1.98 KB, application/octet-stream)
2011-04-01 13:43 EDT, Tobias Oberlies CLA 		no flags Details
Potential fix (1.06 KB, application/octet-stream)
2011-04-01 13:45 EDT, Tobias Oberlies CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Oberlies CLA 2011-04-01 13:43:05 EDT 
Created attachment 192372 [details]
Demostrate bug

The defaults are defined redundantly, and an empty target-platform-configuration yields a different result that no target-platform-configuration.

The latter is wrong: If the target-platform-configuration plug-in is not configured in the build section, ignoreTychoRepositories defaults to "false".
Comment 1 Tobias Oberlies CLA 2011-04-01 13:45:44 EDT 
Created attachment 192374 [details]
Potential fix

This should fix the problem, although I haven't verified this. (Too late for me.) Also I would like to see this fixed more thouroghly: I would like to avoid that the defaults are specified redundantly.
Comment 2 Igor Fedorenko CLA 2011-04-02 00:51:19 EDT 
Applied to master and tycho-0.11.x branches. For 0.12, we should consider getting rid of tycho repositories altogether.
Comment 3 Tobias Oberlies CLA 2011-05-17 03:49:35 EDT 
I did some more refactorings to prevent this class of problems in the future. Closing the issue.