Community
Participate
Working Groups
Build Identifier: 7.0.1 When the "C/C++ Search" dialog is opened it is allowed to keep all "Limit To" checkboxes unchecked, which will always lead to an empty search result. This setting does not make sense at al. As a cosequence this shall be forbidden by the search dialog. Reproducible: Always Steps to Reproduce: See details
Created attachment 193544 [details] The updated PDOMSearchPage class
What would be nice is to add a hint that the C/C++ search only searches in the active code of the project. This regularly confuses our users since they assume it searches the whole src files for the respective element.
(In reply to comment #1) > Created attachment 193544 [details] > The updated PDOMSearchPage class Please provide a patch, your file undos the fix for bug 196479.
Created attachment 194479 [details] Patch for the page class and the properties file containing the externalized strings
Thanks for the patch! The information that the C++ search considers active code branches only is presented in an unusual style. I think it should be sufficient to use a note as for instance on the preference page 'C/C++ - Appearance'.
(In reply to comment #5) > Thanks for the patch! The information that the C++ search considers active code > branches only is presented in an unusual style. I think it should be sufficient > to use a note as for instance on the preference page 'C/C++ - Appearance'. Thas was also my idea, but our users were totally confused of the results since they thought the C/C++ search does a "text based search" but only on the C/C++ code and our users typically don't go through the preferences to find some info about certain features. Who will be hurt if we keep this reminder in the search view? ;) Greets Marko
(In reply to comment #6) > Thas was also my idea, but our users were totally confused of the results since > they thought the C/C++ search does a "text based search" but only on the C/C++ > code and our users typically don't go through the preferences to find some info > about certain features. > Who will be hurt if we keep this reminder in the search view? ;) > Greets Marko I think there is a misunderstanding. The reminder is good, however it should be presented in the usual style: '<bold>Note:</bold> ...'. This style is used by all projects including the platform, we need to stick to it. I mentioned the preference page 'C/C++ - Appearance', because it contains a note in the correct style.
(In reply to comment #7) > (In reply to comment #6) > > Thas was also my idea, but our users were totally confused of the results since > > they thought the C/C++ search does a "text based search" but only on the C/C++ > > code and our users typically don't go through the preferences to find some info > > about certain features. > > Who will be hurt if we keep this reminder in the search view? ;) > > Greets Marko > I think there is a misunderstanding. The reminder is good, however it should be > presented in the usual style: '<bold>Note:</bold> ...'. This style is used by > all projects including the platform, we need to stick to it. > I mentioned the preference page 'C/C++ - Appearance', because it contains a > note in the correct style. Ahh, ok! I will provide another patch for that.
Created attachment 195367 [details] Patch where the note has the right style
Thanks Marko, fixed in 8.0 > 20110511.
*** cdt cvs genie on behalf of mschorn *** Bug 341605: Disable search button for missing element selection, by Marko Tomljenovic. [*] CSearchMessages.properties 1.46 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/search/CSearchMessages.properties?root=Tools_Project&r1=1.45&r2=1.46 [*] PDOMSearchPage.java 1.22 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/search/PDOMSearchPage.java?root=Tools_Project&r1=1.21&r2=1.22 [*] CSearchMessages.java 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/search/CSearchMessages.java?root=Tools_Project&r1=1.16&r2=1.17
