Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341558 - Downloadable server support for Resin
Summary: Downloadable server support for Resin
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: jst.server (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.2.4   Edit
Assignee: Angel Vera CLA
QA Contact: Angel Vera CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-31 18:54 EDT by tundra CLA
Modified: 2017-10-11 16:36 EDT (History)
1 user (show)

See Also:
david_williams: pmc_approved+
arvera: pmc_approved? (raghunathan.srinivasan)
arvera: pmc_approved? (naci.dai)
arvera: pmc_approved? (deboer)
arvera: pmc_approved? (neil.hauge)
arvera: pmc_approved? (kaloyan)
arvera: pmc_approved? (cbridgha)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tundra CLA 2011-03-31 18:54:20 EDT 
Build Identifier: 20100917-0705

Caucho's just finished work on Resin Plugin for Eclipse and would like to add the update site to the site.xml file. 
The update site's URL is http://www.caucho.com/eclipse/


Reproducible: Always
Comment 1 Angel Vera CLA 2011-04-07 08:46:52 EDT 
Tundra for what version are you looking into include this? 3.2.4 or 3.3?
Comment 2 tundra CLA 2011-04-07 11:09:42 EDT 
I think both.. Do I need to create another bug for 3.3?
Comment 3 Angel Vera CLA 2011-04-07 16:52:54 EDT 
No, one bug is fine. I will get this in after the smoke test, possibly tomorrow.
Comment 4 Angel Vera CLA 2011-04-19 16:52:51 EDT 
Tundra, I am adding this for 3.3, but I didn't see the server displayed through the New > Server > Download additional server adapters extension point, fortunately there is no impact on adding a URL that doesn't work so I will just add it for now to 3.2M and 3.3
Comment 5 Angel Vera CLA 2011-04-19 17:14:31 EDT 
changes committed to HEAD (3.3)
Comment 6 Angel Vera CLA 2011-04-19 17:16:42 EDT 
changes released to HEAD(3.3)
Comment 7 Angel Vera CLA 2011-04-19 17:22:03 EDT 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
Without this change the server adapter won't be available through the "download additional adapter" ui

* Is there a work-around? If so, why do you believe the work-around is insufficient? 
Yes, but is a bit convoluted for the user. 

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
I tested that eventhough the URL is not working, it doesn't affect any other function and the produt is still usable, once the URL becomes active the server should be available and downloadable as any of the other servers.

* Give a brief technical overview. Who has reviewed this fix? 
The change is just adding a URL to a xml file

* What is the risk associated with this fix? 
The worst it can happen is that the XML is no in the right format, but I have checked that the URL is proper format and the loading of the xml still works and all the other URLs (for the other server adapters) are still working
Comment 8 tundra CLA 2011-04-19 19:00:33 EDT 
Thanks Angel Vera,

I'll make sure to get the URL to work. I got a copy of the latest from http://download.eclipse.org/eclipse/downloads/ (I20110419-1004)

but that seems to be wrong one.
Alex
Comment 9 Angel Vera CLA 2011-04-19 22:10:01 EDT 
Changes committed to 32M
Comment 10 Angel Vera CLA 2011-04-19 22:11:22 EDT 
Changes released to 32M
Comment 11 Eclipse Genie CLA 2017-10-11 16:36:21 EDT 
New Gerrit change created: https://git.eclipse.org/r/109042