Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341403 - Remove dependency on WTP DTD parser
Summary: Remove dependency on WTP DTD parser
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sapphire (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks:
 
Reported: 2011-03-30 13:43 EDT by Konstantin Komissarchik CLA
Modified: 2021-11-19 09:21 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Komissarchik CLA 2011-03-30 13:43:40 EDT 
When we originally added support for DTDs it made sense to re-use WTP parser as it sped up our implementation. At this point, however, dependency on WTP at this level of the framework restricts certain scenarios where Sapphire could be used. 

Since DTD is such a simple language, we should just implement our own parser.
Comment 1 Konstantin Komissarchik CLA 2011-03-30 19:53:45 EDT 
Done.

Added two unit tests to cover DTD parsing, including entity resolution. Also tried the parser with a variety of complex DTDs that I found.
Comment 2 Konstantin Komissarchik CLA 2011-03-30 19:54:00 EDT 
Done.
Comment 3 Ling Hao CLA 2011-04-15 13:39:37 EDT 
Verified all is well with coherence override 3.5 dtd xml file.