Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341396 - [non-stop] A process that has not been started should be considered as suspended in non-top mode too
Summary: [non-stop] A process that has not been started should be considered as suspen...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 7.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Marc Khouzam CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-30 13:17 EDT by Marc Khouzam CLA
Modified: 2011-03-31 08:58 EDT (History)
2 users (show)

See Also:
marc.khouzam: review? (nobody)

Attachments
Fix (1.19 KB, patch)
2011-03-30 13:17 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
Better fix (1.19 KB, patch)
2011-03-30 13:19 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2011-03-30 13:17:12 EDT 
Created attachment 192211 [details]
Fix

In all-stop mode, before we start the process, we consider the process as suspended.

This is not currently the case for non-stop and I believe it was an oversight.

This is causing me problems when trying to set an initial breakpoint with GDB 7.2 in non-stop.  The problem happens because we think the process is running and we try to interrupt one of its threads, so we request the list of threads, and there are none, since the process isn't started.

The patch fixes that.  Committed to HEAD.
Comment 1 Marc Khouzam CLA 2011-03-30 13:19:01 EDT 
Created attachment 192212 [details]
Better fix

Small typo in previous patch
Comment 2 Marc Khouzam CLA 2011-03-30 13:20:09 EDT 
Pawel, can you review? (3 lines)
Comment 3 CDT Genie CLA 2011-03-30 13:23:03 EDT 
*** cdt cvs genie on behalf of mkhouzam ***
Bug 341396: A process that has not been started should be considered as suspended in non-top mode too

[*] GDBRunControl_7_0_NS.java 1.30 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBRunControl_7_0_NS.java?root=Tools_Project&r1=1.29&r2=1.30
Comment 4 Pawel Piech CLA 2011-03-30 18:37:11 EDT 
(In reply to comment #2)
> Pawel, can you review? (3 lines)

I'm pretty out of touch with the non stop implementation at this point.  So I don't think my review would be very valuable.
Comment 5 Marc Khouzam CLA 2011-03-31 08:58:28 EDT 
(In reply to comment #4)
> (In reply to comment #2)
> > Pawel, can you review? (3 lines)
> 
> I'm pretty out of touch with the non stop implementation at this point.  So I
> don't think my review would be very valuable.

I understand.

Mikhail, can you review instead?