Community
Participate
Working Groups
- we now have API for making the popup appear closer to the cursor - sometimes the text writes outside of the div (width is not right) - should be able to ESC out of it - we originally scoped the search to only files of the current file type. I think this restriction was introduced in the beginning when we had performance problems with global search (pre Solr). There's no need for this restriction now and I find it confusing because it means the search results in the popup are different than what you get in the search bar.
*** Bug 334042 has been marked as a duplicate of this bug. ***
Also, I would expect clicking in the editor outside the popup would close the popup.
(In reply to comment #0) > - we now have API for making the popup appear closer to the cursor Since the results can be quite big, I've decided against this. > - sometimes the text writes outside of the div (width is not right) This was fixed some time ago. > - should be able to ESC out of it Fixed while dealing with related Esc issues in bug 348792 > - we originally scoped the search to only files of the current file type. I > think this restriction was introduced in the beginning when we had performance > problems with global search (pre Solr). There's no need for this restriction > now and I find it confusing because it means the search results in the popup > are different than what you get in the search bar. Look at this for RC2, it's a small change (In reply to comment #2) > Also, I would expect clicking in the editor outside the popup would close the > popup. will look at this and do whatever content assist does
(In reply to comment #3) > > - we originally scoped the search to only files of the current file type. I > > think this restriction was introduced in the beginning when we had performance > > problems with global search (pre Solr). There's no need for this restriction > > now and I find it confusing because it means the search results in the popup > > are different than what you get in the search bar. > > Look at this for RC2, it's a small change I have a proposed fix in the git branch remotes/origin/bug341395. > > (In reply to comment #2) > > Also, I would expect clicking in the editor outside the popup would close the > > popup. > > will look at this and do whatever content assist does This is not as easily done as it sounds. I think it's better to fix this as part of a comprehensive look at editor modes, which is described in bug 348823.
adding John for review. I propose that for RC2 we remove the old code that scoped editor-triggered searches to the file type of the editor. This ensures that the search results returned by ctrl-H and those returned when you type in the searchbox are consistent.
In case it was too buried in other remarks, the branch to review is remotes/origin/bug341395.
Looks good. I tested searches in various file types in a large workspace. The search speed is certainly not a problem so I think this makes sense.
pushed.
