Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341390 - Upgrade AspectJ to 1.6.11 or later
Summary: Upgrade AspectJ to 1.6.11 or later
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: runtime (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL: http://www.eclipse.org/forums/index.p...
Whiteboard:
Keywords:
Depends on: 341130
Blocks: 327204
  Show dependency tree
 
Reported: 2011-03-30 12:10 EDT by Glyn Normington CLA
Modified: 2012-05-04 09:42 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Glyn Normington CLA 2011-03-30 12:10:16 EDT

    
Comment 1 Andrew Clement CLA 2011-03-30 12:31:22 EDT
Glyn - there is an AspectJ bug I raised against 1.6.11 that came about due to me investigating a problem Steve raised a while back.  Steves issue was bug 292239 - that is now fixed, but whilst investigating it revealed an inadvertent change in matching that came about due to a large scale refactoring/performance pass in AspectJ 1.6.8.  The new issue is bug 341130.  I don't know whether you are still relying on the matching occurring as Steves example showed in 292239 but if you are, there may be issues with you jumping to 1.6.11.

I haven't yet decided if the change in matching is a regression or was just me closing an accidental hole - the behaviour isn't very well spec'd for the scenario.

Anyway, I just mention this to give you a heads up - a lot changed around the 1.6.8 timeframe (driven by a requirement for performance/memory improvements), but I'm sure your tests will pick up on anything weird.
Comment 2 Glyn Normington CLA 2011-03-31 04:32:30 EDT
Hi Andy

Thanks for pointing that out. As the linked forum thread shows, users can successfully upgrade Virgo to AspectJ 1.6.10 on their own, so this enhancement can be treated as low priority.

I'm not convinced our tests cover exception throwing from JMX invocations well if at all, so let's hold off implementing this enhancement until bug 341130 is fixed (assuming that will allow us to switch from the workaround to Steve's example code attached to bug 292339).

Regards,
Glyn
Comment 3 Chris Frost CLA 2012-05-04 09:35:57 EDT
This has happened now, we have been on aspectJ 1.6.12 for a few months.