Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341369 - CompositeEditorFactoriesRegistry : inverted type comparison
Summary: CompositeEditorFactoriesRegistry : inverted type comparison
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-30 10:27 EDT by Nicolas Bros CLA
Modified: 2020-05-01 11:27 EDT (History)
2 users (show)

See Also:
nicolas.bros: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-03-30 10:27:42 EDT 
In CompositeEditorFactoriesRegistry#getCompositeEditorFactory, the factory checks if the type is handled by a given cell editor. But it doesn't work for subtypes.

The comparison is currently:
objectType.isAssignableFrom(handledType)
It should be instead:
handledType.isAssignableFrom(objectType)
Comment 1 Nicolas Bros CLA 2011-03-30 10:28:59 EDT 
Fixed in revision 477.
Comment 2 Gregoire Dupe CLA 2011-06-08 10:53:46 EDT 
I assume this bug can be closed, but a unit test would have been welcomed to help the reviewer to check the correctness of the fix.