Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341287 - o.e.e.p2.transport.ecf bundle needlessly includes org.eclipse.core.runtime
Summary: o.e.e.p2.transport.ecf bundle needlessly includes org.eclipse.core.runtime
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-29 17:06 EDT by Scott Lewis CLA
Modified: 2011-03-29 17:19 EDT (History)
0 users

See Also:

Attachments
patch to eliminate require-bundle dependency on o.e.core.runtime (1.37 KB, patch)
2011-03-29 17:15 EDT, Scott Lewis CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Lewis CLA 2011-03-29 17:06:40 EDT 
In the newly added bundle:  org.eclipse.equinox.p2.transport.ecf 

the manifest.mf has:

Require-Bundle: org.eclipse.ecf;bundle-version="3.1.0",
 org.eclipse.ecf.filetransfer;bundle-version="4.0.0",
 org.eclipse.ecf.provider.filetransfer;bundle-version="3.1.0",
 org.eclipse.core.runtime;bundle-version="3.6.100",              <----
 org.eclipse.equinox.p2.core;bundle-version="2.0.100",
 org.eclipse.equinox.p2.repository;bundle-version="2.1.0"

This means that org.eclipse.core.runtime gets pulled into any application (e.g. osgi server-side app) that uses both p2 and the ECF filetransfer.  It would be much better to require-bundle with equinox common, and include packages for the other dependencies so as to eliminate the need for org.eclipse.core.runtime.

See also bug 341285 for bug in p2 server feature that is missing the o.e.e.p2.transport.ecf bundle.
Comment 1 Scott Lewis CLA 2011-03-29 17:15:12 EDT 
Created attachment 192144 [details]
patch to eliminate require-bundle dependency on o.e.core.runtime

This patch removes the Require-Bundle dependency on org.eclipse.core.runtime and replaces it with Require-Bundle on org.eclipse.equinox.common plus a number of Import-Package of various packages (jobs, osgi packageadmin, tracker, etc).
Comment 2 DJ Houghton CLA 2011-03-29 17:19:22 EDT 
Thanks Scott. I actually fixed this just before seeing your patch. I just changed the require bundle to include osgi and jobs and common.