Comment 1 Vincent Lorenzo 2011-03-29 10:46:37 EDT

Created attachment 192097 [details]
Add useful methods to find elements in customization

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 2 Gregoire Dupe 2011-03-30 03:55:30 EDT

Comment on attachment 192097 [details]
Add useful methods to find elements in customization

Hello Vincent,

Please could you use EPackage, EClass, EReference and EAttribute in place of String as the parameters types?

Regards,
Gregoire

Comment 3 Vincent Lorenzo 2011-03-30 05:27:53 EDT

Created attachment 192168 [details]
Add useful methods to find elements in customization

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 4 Vincent Lorenzo 2011-03-30 07:27:26 EDT

Created attachment 192177 [details]
Minors changes to facilitate inheritance for LoadCustomizationDialog

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 5 Gregoire Dupe 2011-03-30 08:10:33 EDT

Comment on attachment 192168 [details]
Add useful methods to find elements in customization

Partick, please can you commit this patch ?

Comment 6 Gregoire Dupe 2011-03-30 08:14:32 EDT

Comment on attachment 192177 [details]
Minors changes to facilitate inheritance for LoadCustomizationDialog

Patrick, please, can you commit this patch ?

Comment 7 Patrick Tessier 2011-03-30 09:15:37 EDT

Comment on attachment 192168 [details]
Add useful methods to find elements in customization

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 476.

Comment 8 Patrick Tessier 2011-03-30 09:15:55 EDT

Comment on attachment 192177 [details]
Minors changes to facilitate inheritance for LoadCustomizationDialog

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 476.

Comment 9 Vincent Lorenzo 2011-03-30 09:53:37 EDT

Created attachment 192188 [details]
This patch allows to store hidden/visible columns in local customization file and to apply it. + preferences pages

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 10 Vincent Lorenzo 2011-03-30 10:03:58 EDT

Created attachment 192190 [details]
This patch allows to store hidden/visible columns in local customization file and to apply it. + preferences pages

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 11 Gregoire Dupe 2011-03-30 13:14:58 EDT

Hello,

To allow dependencies from org.eclipse.emf.facet.widgets.nattable, I've add x-friends in org.eclipse.emf.facet.infra.browser.custom.ui and in org.eclipse.emf.facet.infra.browser.uicore.

Committed revision 478.

Regards,
Gregoire

Comment 12 Vincent Lorenzo 2011-04-05 04:26:47 EDT

Created attachment 192528 [details]
Add a method to get all elements which own a feature.

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 13 Vincent Lorenzo 2011-04-05 04:28:21 EDT

Created attachment 192529 [details]
This patch allows to store hidden/visible columns in local customization file and to apply it. + preferences pages

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 14 Vincent Lorenzo 2011-04-06 04:07:54 EDT

Created attachment 192620 [details]
This patch allows to store hidden/visible columns in local customization file and to apply it. + preferences pages

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 15 Gregoire Dupe 2011-04-06 09:30:20 EDT

Comment on attachment 192620 [details]
This patch allows to store hidden/visible columns in local customization file and to apply it. + preferences pages

Nicolas, please, can you review this contribution.

Comment 16 Nicolas Bros 2011-04-06 11:20:07 EDT

Comment on attachment 192620 [details]
This patch allows to store hidden/visible columns in local customization file and to apply it. + preferences pages

(In reply to comment #15)
> Nicolas, please, can you review this contribution.

I have a few remarks:
- In NatTablePreferencePage, you should distinguish the string displayed to the user ("Yes" or "No") from the constant stored in the configuration file (it could  perhaps be defined as an enumeration, or at least a separate constant). Otherwise it will stop working when the strings will get translated.
- In NatTableWidget#getHiddenAttributeColumnStatus, line 1463, you initialize "value" with a negated value:
boolean value = !customizationEngine.isAttributeVisibleStatic(...)
and then compare it with:
if (value != !this.customizationEngine.isAttributeVisibleStatic(...)
Could you simplify these multiple negations? And rename "value" to isVisible, or isHidden (I couldn't figure out which one was right) to make it clear what it represents
- Same thing in NatTableWidget#getHiddenReferenceColumnStatus
- The javadoc of NatTableWidgetLoadCustomizationsDialog is cut mid-sentence (line 38)
- In NatTableWidgetLoadCustomizationsDialog#filterForMetamodel, you duplicated the code from the super method. Could you instead get the filtered list from super.filterForMetamodel(..) and add your element?
- NatTableWidgetLoadCustomizationsDialog$ColorLabelProvider#getImage should either not create a new Image each time it is called, or dispose() it to avoid leaking image handles

Comment 17 Gregoire Dupe 2011-04-06 11:39:47 EDT

Comment on attachment 192528 [details]
Add a method to get all elements which own a feature.

Patrick, please, can you commit this patch ?

Comment 18 Gregoire Dupe 2011-04-06 11:40:44 EDT

Comment on attachment 192620 [details]
This patch allows to store hidden/visible columns in local customization file and to apply it. + preferences pages

Patrick, please, can you commit this patch ?

The modifications proposed by Nicolas will provided in an other patch.

Comment 19 Vincent Lorenzo 2011-04-07 02:57:50 EDT

Created attachment 192699 [details]
This patch add the documentation for the "Select Columns To Hide action" + preferences

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 20 Vincent Lorenzo 2011-04-07 03:00:36 EDT

Created attachment 192700 [details]
Images for the new documentation for "Select Columns To Hide" + preferences

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 21 Gregoire Dupe 2011-04-07 05:49:38 EDT

Comment on attachment 192699 [details]
This patch add the documentation for the "Select Columns To Hide action" + preferences

Patrick, please, can you commit this contribution.

Comment 22 Gregoire Dupe 2011-04-07 05:52:12 EDT

Comment on attachment 192700 [details]
Images for the new documentation for "Select Columns To Hide" + preferences

Patrick, please, can you commit the contribution.

Comment 23 Patrick Tessier 2011-04-07 08:26:26 EDT

Comment on attachment 192528 [details]
Add a method to get all elements which own a feature.

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 502.

Comment 24 Patrick Tessier 2011-04-07 08:26:44 EDT

Comment on attachment 192620 [details]
This patch allows to store hidden/visible columns in local customization file and to apply it. + preferences pages

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 502.

Comment 25 Patrick Tessier 2011-04-07 08:26:59 EDT

Comment on attachment 192699 [details]
This patch add the documentation for the "Select Columns To Hide action" + preferences

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 502.

Comment 26 Patrick Tessier 2011-04-07 08:27:13 EDT

Comment on attachment 192700 [details]
Images for the new documentation for "Select Columns To Hide" + preferences

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 502.

Comment 27 Gregoire Dupe 2011-04-08 12:19:57 EDT

Hello,

I've committed a refactoring of the method org.eclipse.emf.facet.widgets.nattable.internal.NatTableWidget.selectColumnsToHide() to be able to easily write unit test to the dialogs.

This refactoring has to be finished.

Committed revision 505.

Regards,
Grégoire

Comment 28 Vincent Lorenzo 2011-04-12 03:53:41 EDT

Created attachment 193005 [details]
Add the grayed icon for uiCustom in the Image Provider

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 29 Vincent Lorenzo 2011-04-12 04:14:06 EDT

Created attachment 193007 [details]
Following of the refactoring + bring the changes wanted in Comment 15

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 30 Vincent Lorenzo 2011-04-12 11:40:57 EDT

Created attachment 193058 [details]
Following of the refactoring + bring the changes wanted in Comment 15

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 31 Gregoire Dupe 2011-04-12 12:07:13 EDT

Comment on attachment 193005 [details]
Add the grayed icon for uiCustom in the Image Provider

Patrick, please, can you commit this patch ?

Comment 32 Gregoire Dupe 2011-04-12 12:16:53 EDT

Comment on attachment 193058 [details]
Following of the refactoring + bring the changes wanted in Comment 15

Patrick, please, can you:
-	add the copyright header in IPutOnTheTopQuestionDialog  and PutOnTheTopQuestionDialog
-	commit the patch.

Comment 33 Vincent Lorenzo 2011-04-14 07:43:14 EDT

Created attachment 193242 [details]
This patch allows to show/hide the FacetColumns with the local custom files

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 34 Vincent Lorenzo 2011-04-14 07:47:54 EDT

Created attachment 193243 [details]
Following of the refactoring + bring the changes wanted in Comment 15

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 35 Vincent Lorenzo 2011-04-14 07:51:58 EDT

Created attachment 193244 [details]
The JUnit tests for the ShowHide Columns

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 36 Vincent Lorenzo 2011-04-14 08:40:16 EDT

Created attachment 193248 [details]
Add an example for table with Facet Columns Hidden

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 37 Gregoire Dupe 2011-04-15 08:12:14 EDT

Comment on attachment 193005 [details]
Add the grayed icon for uiCustom in the Image Provider

Here is a path smaller than 250 lines, no CQ is then needed.

I've committed this patch.

Committed revision 521.

Comment 38 Gregoire Dupe 2011-04-15 12:51:43 EDT

Comment on attachment 193242 [details]
This patch allows to show/hide the FacetColumns with the local custom files

Partick, please, can you commit this patch.

Comment 39 Gregoire Dupe 2011-04-15 12:59:22 EDT

Comment on attachment 193243 [details]
Following of the refactoring + bring the changes wanted in Comment 15

Partick, please, can you commit this patch.

Comment 40 Gregoire Dupe 2011-04-15 12:59:43 EDT

Comment on attachment 193248 [details]
Add an example for table with Facet Columns Hidden

Partick, please, can you commit this patch ?

Comment 41 Patrick Tessier 2011-04-18 06:20:05 EDT

Comment on attachment 193242 [details]
This patch allows to show/hide the FacetColumns with the local custom files

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 522.

Comment 42 Patrick Tessier 2011-04-18 06:22:25 EDT

Comment on attachment 193243 [details]
Following of the refactoring + bring the changes wanted in Comment 15

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 523.

Comment 43 Patrick Tessier 2011-04-18 09:46:31 EDT

Comment on attachment 193248 [details]
Add an example for table with Facet Columns Hidden

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 524.

Comment 44 Vincent Lorenzo 2011-04-20 04:45:47 EDT

Created attachment 193668 [details]
The JUnit Tests for the ShowHide Columns

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 45 Vincent Lorenzo 2011-04-20 04:48:45 EDT

Created attachment 193669 [details]
Add the localCustom file to the customization list in the tableinstance + correct methods for JUnit Test in ColumnsToHideDialog

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 46 Vincent Lorenzo 2011-04-21 10:45:08 EDT

Created attachment 193837 [details]
correct methods for JUnit Test in ColumnsToHideDialog + move some lines of code

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 47 Vincent Lorenzo 2011-04-21 10:46:35 EDT

Created attachment 193838 [details]
The test of ShoHide column in a new class!

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 48 Vincent Lorenzo 2011-04-26 10:44:33 EDT

Created attachment 194062 [details]
The JUnit Test for Show Hide Columns in a new File + use syncExec to test the dialogs

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 49 Vincent Lorenzo 2011-04-26 10:47:07 EDT

Created attachment 194063 [details]
The JUnit Test for Show Hide Columns in a new File + use syncExec to test the dialogs

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 50 Vincent Lorenzo 2011-04-26 10:48:33 EDT

Created attachment 194064 [details]
correct methods for JUnit Test in ColumnsToHideDialog + move some lines of code

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 51 Gregoire Dupe 2011-04-26 13:11:20 EDT

Hello,

I've added an x-friend to test the use of the customization in a table.

Committed revision 581.

Grégoire

Comment 52 Vincent Lorenzo 2011-04-27 06:07:22 EDT

Created attachment 194137 [details]
The JUnit Test for Show Hide Columns in a new File + use syncExec to test the dialogs

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 53 Gregoire Dupe 2011-05-02 10:17:28 EDT

Comment on attachment 194064 [details]
correct methods for JUnit Test in ColumnsToHideDialog + move some lines of code

I've committed this contribution.

This patch is smaller than 250 lines: no CG are needed.

Committed revision 598.

Comment 54 Gregoire Dupe 2011-05-02 10:18:50 EDT

Comment on attachment 194137 [details]
The JUnit Test for Show Hide Columns in a new File + use syncExec to test the dialogs

Patrick, please, can you commit this bug.

Regards,
Gregoire Dupe

Comment 55 Patrick Tessier 2011-05-02 10:50:16 EDT

Comment on attachment 194137 [details]
The JUnit Test for Show Hide Columns in a new File + use syncExec to test the dialogs

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 599.

Comment 56 Gregoire Dupe 2011-05-20 10:36:42 EDT

Hello,

I think this bug can is resolved.

Vincent, if you agree with me, please, can you close this bug.

Regards,
Gregoire Dupe

Comment 57 Vincent Lorenzo 2011-05-20 10:42:22 EDT

This bug can be marked as closed.