Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341224 - GFPaletteRoot will always add selection tools. These should be optional
Summary: GFPaletteRoot will always add selection tools. These should be optional
Status: CLOSED FIXED
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.9.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: Juno M4 Theme_round_offs
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-29 08:44 EDT by Torkild Resheim CLA
Modified: 2012-06-29 04:12 EDT (History)
2 users (show)

See Also:
michael.wenz: juno+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torkild Resheim CLA 2011-03-29 08:44:12 EDT 
In some use cases one does not want the selection tools to be in the palette. Hence it should be possible to not add these. Currently GFPaletteRoot will always add the selection tools. 

Note that there also appears to be no way of customising this section of the palette. Maybe this type of tools should be handled similar to the creation tools? I.e. allowing the FeatureProvider to supply the tools to be placed in that section.
Comment 1 Torkild Resheim CLA 2011-03-29 09:07:53 EDT 
Well I did find a way of overriding this behaviour; by subclassing the Graphiti editor and implementing *createPaletteRoot()*. Since we already have our own editor this works for us so I'm not going to spend more time on this issue. I'm leaving it open in case you guys want to handle it otherwise.
Comment 2 Michael Wenz CLA 2011-07-18 07:22:03 EDT 
Would like to target for Juno
Comment 3 Michael Wenz CLA 2011-11-24 10:12:22 EST 
I added 2 methods to the tool behaviour provider that allow tool builders to prevent the selection tool and/or the marquee tool from appearing in the palette.
I also added a test for this.
Checked-in to head and pushed to Eclipse:
commit c4e53155eb6b3324fb202c5936186eaac4a94f1d
Author: mwenz <michael.wenz@sap.com> 2011-11-24 16:08:59
Committer: mwenz <michael.wenz@sap.com> 2011-11-24 16:08:59
Parent: 2998206489c6883a255033ce10498cdb361e5db0 (Bug 349416: Support drag&drop operations on FixPointAnchors the same way as for BoxRelativeAnchors)
Branches: origin/master, master
Comment 4 Michael Wenz CLA 2012-04-11 10:43:32 EDT 
Bookkeeping: Set target release
Comment 5 Michael Wenz CLA 2012-06-29 04:12:37 EDT 
Part of Graphiti 0.9.0 (Eclipse Juno)